Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins job filtering by regex not preserved when selecting actual job #532

Closed
DimitarPetrov opened this issue Aug 17, 2019 · 3 comments
Closed

Jenkins job filtering by regex not preserved when selecting actual job #532

DimitarPetrov opened this issue Aug 17, 2019 · 3 comments
Labels
🐛 bug "Houston, we've had a problem."

Comments

@DimitarPetrov
Copy link

When i specify a regex that filters the jobs shown in the Jenkins widget the visual result is as expected. Unfortunately when i try to navigate to the desired job with the arrow keys, it seems like the filtering is not preserved and even though you don't see some of them you still iterate over all existing jobs and not only the jobs matched by the regex in configuration.
@DimitarPetrov DimitarPetrov changed the title Jenkins job filtering by regex not preserved when selecting actual job. Jenkins job filtering by regex not preserved when selecting actual job Aug 17, 2019
Seanstoppable added a commit to Seanstoppable/wtf that referenced this issue Aug 17, 2019
@Seanstoppable
Move jenkins filter to the data retrieval portion
f2cb306 
Per wtfutil#532, we are keeping track of all items regardless of filter,
meaning that selection does not work as expected
@Seanstoppable Seanstoppable mentioned this issue Aug 17, 2019
Merged
@Seanstoppable
Copy link
Collaborator

You are correct that we are filtering jobs at view time, and this impacts selection. Want to give #533 a shot? I unfortunately do not have a jenkins server to test against at this time.

@Seanstoppable Seanstoppable added the 🐛 bug "Houston, we've had a problem." label Aug 17, 2019
@DimitarPetrov
Copy link
Author

@Seanstoppable
Thank you for the fast response!
I just tested it and it works fine.

Seanstoppable added a commit that referenced this issue Aug 17, 2019
@Seanstoppable
Move jenkins filter to the data retrieval portion (#533)
28f9b55 
Per #532, we are keeping track of all items regardless of filter,
meaning that selection does not work as expected
@Seanstoppable
Copy link
Collaborator

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug "Houston, we've had a problem."
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Seanstoppable @DimitarPetrov