Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Jira module title formatting #942

Closed
timhwang21 opened this issue Jul 27, 2020 · 0 comments · Fixed by #944
Closed

Bug: Jira module title formatting #942

timhwang21 opened this issue Jul 27, 2020 · 0 comments · Fixed by #944
Labels
🐛 bug "Houston, we've had a problem."

Comments

@timhwang21
Copy link
Contributor

What's broken?

Screen Shot 2020-07-26 at 9 09 23 PM

My config (relevant parts):

    jira:
      title: " Jira"
      projects: ["Persona"]

Broken part in code: modules/jira/widget.go#L80

Problem: widget.settings.project is an array, so gets stripped out during printing (I assume because it's treated as a color code).

(My personal suggested fix would just be to remove this extra stuff, it doesn't seem useful to me and the user can always put the project name in title if they want. Or maybe it can show issue count after the hyphen. Would be happy to file a PR either way!)

Nit 1: the code documentation says that the project(s) are passed as:

	projects                []string `help:"An array of projects to get data from"`

...but it is in fact project and not projects.

Nit 2: there is no whitespace between the word Jira and the hyphen, which I don't think looks good. (The Hackernews module has a space before and after the hyphen.)

@senorprogrammer senorprogrammer added the 🐛 bug "Houston, we've had a problem." label Jul 27, 2020
timhwang21 added a commit to timhwang21/wtf that referenced this issue Jul 29, 2020
Closes wtfutil#942. Filing to get the ball rolling, happy to change anything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug "Houston, we've had a problem."
Development

Successfully merging a pull request may close this issue.

2 participants