Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WTF-986 User-definable DigitalOcean columns #1001

Merged
merged 4 commits into from
Oct 14, 2020

Conversation

senorprogrammer
Copy link
Collaborator

@senorprogrammer senorprogrammer commented Oct 13, 2020

This PR allows the user to define which droplet property columns to display, by defining them as a list in their config. Falls back to a default set of columns if none are explicitly defined.

The new settings look like:

digitalocean:
    columns:
        - Name
        - Status
        - Vcpus
        - Disk
        - Memory
        - Region.Slug

In this case it would display those six columns. If no config settings are defined, the default set is used:

var defaultColumns = []interface{}{
	"Name",
	"Status",
	"Region.Slug",
}

Valid configuration values are any publicly-accessible properties on a DigitalOcean Droplet, Image, Region, or Size.

See https://github.com/digitalocean/godo for more details about those.

Closes #986.

This gives us something to build off while still providing the
underlying functionality of the original droplet instance.

Signed-off-by: Chris Cummer <[email protected]>
@senorprogrammer senorprogrammer marked this pull request as draft October 13, 2020 19:50
@senorprogrammer senorprogrammer marked this pull request as ready for review October 13, 2020 20:11
@senorprogrammer senorprogrammer changed the title WTF-986 User-definable DigitalOcean Columns WTF-986 User-definable DigitalOcean columns Oct 13, 2020
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@senorprogrammer senorprogrammer merged commit f841425 into master Oct 14, 2020
@Seanstoppable Seanstoppable deleted the WTF-986-digitalocean-columns branch February 24, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

DigitalOcean module should allow columns to be configurable
1 participant