Make the cmdrunner more interactive #680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the cmdrunner executes the command once for each update interval which delays the update for other widgets and prevents users from using longer running commands (like watching a log or requesting data from very slow servers). This PR fixes the problem by running the command concurrently and updating the view each time the command outputs data.
It also adds two config parameters:
tail
which causes the widget to scroll to the end of new output (interesting for following log files)maxLines
which limits the number of lines kept in the buffer (to prevent the widget from consuming unlimited memory)Also the widget is now focusable to allow the user to scroll in the output.