Skip to content

Commit

Permalink
[#357] Issue description moved to ResolutionModifier wiki, referenced…
Browse files Browse the repository at this point in the history
… in UpgradeNotes
  • Loading branch information
tkaik committed Sep 21, 2018
1 parent 1089d53 commit bd01062
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 26 deletions.
29 changes: 29 additions & 0 deletions documentation/src/main/wiki/ResolutionModifier.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,35 @@ Module name: **resolution**
</suite>
```

##### Known issues

[#357](https://github.com/Cognifide/aet/issues/357) - If you're using the auto-height calculation feature of [[Resolution Modifier|ResolutionModifier]], it may happen that the
height of collected screenshot is different every time you run the suite, which results in failures on the report.
Currently you can use one of following workarounds to fix this issues:
* specify the `height` parameter manually with a value which is equal or greater than the height of page you want to test, e.g.:
```$xml
<open/>
<resolution width="1366" height="5000"/>
<scren/>
```
* use an additional `resolution` modifier with any `height` (value doesn't matter) before the `open` phase - to ensure that
the page will be opened with desired `width` and the 2nd `resolution` will only compute and change the height.
```$xml
<resolution width="1366" height="100"/>
<open/>
<resolution width="1366"/>
<scren/>
```
* use two `resolution` modifiers with the same `width` attribute (the first one may also have `height` attribute with any value)
and a `sleep` modifier between them, e.g:
```$xml
<open/>
<resolution width="1366"/>
<sleep duration="1000"/>
<resolution width="1366"/>
<scren/>
```

#### Tips and tricks

In order to make sure that your screenshots have the resolution you expect them to have you need to test it first.
Expand Down
28 changes: 2 additions & 26 deletions documentation/src/main/wiki/UpgradeNotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,32 +25,8 @@ Please see latest [[Screen Collector|ScreenCollector]] and [[Resolution Modifier

##### Known issues

[#357](https://github.com/Cognifide/aet/issues/357) - If you're using the auto-height calculation feature of [[Resolution Modifier|ResolutionModifier]], it may happen that the
height of collected screenshot is different every time you run the suite, which results in failures on the report.
Currently you can use one of following workarounds to fix this issues:
* specify the `height` parameter manually with a value which is equal or greater than the height of page you want to test, e.g.:
```$xml
<open/>
<resolution width="1366" height="5000"/>
<scren/>
```
* use an additional `resolution` modifier with any `height` (value doesn't matter) before the `open` phase - to ensure that
the page will be opened with desired `width` and the 2nd `resolution` will only compute and change the height.
```$xml
<resolution width="1366" height="100"/>
<open/>
<resolution width="1366"/>
<scren/>
```
* use two `resolution` modifiers with the same `width` attribute (the first one may also have `height` attribute with any value)
and a `sleep` modifier between them, e.g:
```$xml
<open/>
<resolution width="1366"/>
<sleep duration="1000"/>
<resolution width="1366"/>
<scren/>
```
* [#357](https://github.com/Cognifide/aet/issues/357) - see Known issues section in [[Resolution Modifier|ResolutionModifier]] wiki
for possible workarounds.

#### `aet-maven-plugin` marked as deprecated
That means it will be no longer supported after release of this version and expect it will be removed soon.
Expand Down

0 comments on commit bd01062

Please sign in to comment.