Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a feature that will allow monitoring the size of responses for the given requests #501

Closed
krzysztofryk opened this issue Apr 8, 2019 · 1 comment
Closed

Implement a feature that will allow monitoring the size of responses for the given requests #501

krzysztofryk opened this issue Apr 8, 2019 · 1 comment
Labels
enhancement help wanted Hey, contributor! We need your help. sum20

Comments

@krzysztofryk
Copy link

krzysztofryk commented Apr 8, 2019 •
edited
Loading

Feature description
Implement an additional Collector and Comparator that will allow one to sum the transferred data of the responses for the given/filtered requests.

Adding this feature will allow monitoring the growth of the page size over time and to alert if the amount of the transferred data is bigger than an assumed threshold.

Example
Consider an example where one does not configure the images renditions behaviour properly and effectively downloads the original version of these on mobile devices. It is relatively easy to overlook such an issue in the ongoing development without automating this test case.

Configurable elements

  • urlPattern in the Collector definition
  • maxSize in the Comparator definition

Report
The additional tab should be displayed in the report

  • the information about the overall amount of the transferred data
  • the table of ordered requests (desc) and their attributes (URL as a link, Size in kilobytes)
krzysztofryk pushed a commit to krzysztofryk/aet that referenced this issue Apr 9, 2019
Implement a monitoring of the size of responses for the given requests
7e29ba6 
Implement an additional Collector and Comparator that will allow one to sum the transferred data of the responses for the given/filtered requests. Added a simple report that shows the information about the overall amount of the transferred data and the table of ordered requests (desc) and their attributes (URL as a link, Size in kilobytes)

wttech#501

I hereby agree to the terms of the AET Contributor License Agreement.
krzysztofryk pushed a commit to krzysztofryk/aet that referenced this issue Apr 9, 2019
Refactor of RequestMonitoringCollector
812f957 
Implement an additional Collector and Comparator that will allow one to sum the transferred data of the responses for the given/filtered requests. Added a simple report that shows the information about the overall amount of the transferred data and the table of ordered requests (desc) and their attributes (URL as a link, Size in kilobytes)

wttech#501

I hereby agree to the terms of the AET Contributor License Agreement.
@krzysztofryk krzysztofryk mentioned this issue Apr 9, 2019
Merged
5 tasks
krzysztofryk pushed a commit to krzysztofryk/aet that referenced this issue Apr 9, 2019
Changelog update (add Request Monitoring feature)
ee56bde 
Implement an additional Collector and Comparator that will allow one to sum the transferred data of the responses for the given/filtered requests. Added a simple report that shows the information about the overall amount of the transferred data and the table of ordered requests (desc) and their attributes (URL as a link, Size in kilobytes)

wttech#501

I hereby agree to the terms of the AET Contributor License Agreement.
krzysztofryk pushed a commit to krzysztofryk/aet that referenced this issue Apr 12, 2019
Code refactor
f335063 
Implement an additional Collector and Comparator that will allow one to sum the transferred data of the responses for the given/filtered requests. Added a simple report that shows the information about the overall amount of the transferred data and the table of ordered requests (desc) and their attributes (URL as a link, Size in kilobytes)

wttech#501

I hereby agree to the terms of the AET Contributor License Agreement.
@radeklawgmin radeklawgmin added smu20 and removed sum19 labels Jun 4, 2020
@tMaxx tMaxx added sum20 and removed smu20 labels Aug 6, 2020
@tMaxx tMaxx added the help wanted Hey, contributor! We need your help. label Sep 7, 2020
@mariuszkubis mariuszkubis self-assigned this Sep 25, 2020
@mariuszkubis mariuszkubis mentioned this issue Oct 16, 2020
Merged
2 tasks
@basia-wulnikowska
Copy link
Contributor

Reports are working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted Hey, contributor! We need your help. sum20
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tMaxx @krzysztofryk @mariuszkubis @radeklawgmin @basia-wulnikowska