Timeout-based integration tests stabilization for Chrome #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified timeouts on Sample Site and Test Suite to fix tests results for SeleniumGrid+Chrome migration. Updated functional tests
tkaik
commented
Aug 6, 2018
| @@ -29,9 +29,9 @@ | |||
| @Modules(GuiceModule.class) | |||
| public class HomePageTilesTest { | |||
|
|
|||
| private static final int TESTS = 113; | |||
| private static final int TESTS = 115; | |||
There was a problem hiding this comment.
Two tests have been added in this PR: #294
malaskowski
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified timeouts on Sample Site and Test Suite.
to fix tests results for SeleniumGrid+Chrome migration.
Updated functional (Bobcat) tests.
Motivation and Context
In codebase there are some tests which are expected e.g. to take a screenshot before some timeout-based javascript code is executed on a page. To get the same test results on Selenium Grid + Chrome setup, those timeouts need to be increased - it seems that Chromedriver needs more time to complete the
openphase (than the old Firefox, without Selenium Grid) - by default it's usingnormalpage load strategyScreenshots (if appropriate):
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.