Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default web driver changed from Firefox to Chrome #327

Merged
merged 2 commits into from
Aug 21, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ All notable changes to AET will be documented in this file.
## Unreleased
**List of changes that are finished but not yet released in any final version.**

- [PR-327](https://github.com/Cognifide/aet/pull/327) Default web driver changed from Firefox to Chrome
- [PR-294](https://github.com/Cognifide/aet/pull/294) Added support for full page screenshot in chrome
- [PR-293](https://github.com/Cognifide/aet/pull/293) Added error treshold in pixels and percentages for screen comparator
- [PR-300](https://github.com/Cognifide/aet/pull/300) Added creating indexes for collection
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public class WebDriverProvider {

private static final String DEFAULT_WEB_DRIVER_NAME = "defaultWebDriverName";

@Property(name = DEFAULT_WEB_DRIVER_NAME, label = "Default Web Driver name", value = "ff")
@Property(name = DEFAULT_WEB_DRIVER_NAME, label = "Default Web Driver name", value = "chrome")
private String defaultWebDriverName;

@Reference(referenceInterface = WebDriverFactory.class, policy = ReferencePolicy.DYNAMIC, cardinality = ReferenceCardinality.OPTIONAL_MULTIPLE, bind = "bindWebDriverFactory", unbind = "unbindWebDriverFactory")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@

@Service
@Component(
policy = ConfigurationPolicy.REQUIRE,
description = "AET Chrome WebDriver Factory",
label = "AET Chrome WebDriver Factory",
metatype = true)
Expand Down
12 changes: 12 additions & 0 deletions documentation/src/main/wiki/UpgradeNotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,15 @@ You may see all changes in the [Changelog](https://github.com/Cognifide/aet/blob

## Unreleased

### BrowserMob Proxy server connection
The address of BrowserMob Proxy server is set to `localhost:8080` by default (in Karaf config) -
it's used by workers to connect to the proxy server. Previously, when tests were being run on local Firefox instances
running on the same machine as the proxy server, there was no need to change the default config.
Currently, when tests are executed on Selenium Grid nodes on different machines, the address of proxy
server must be configured to an IP/host name which is accessible for the nodes.
It can be configured in `com.cognifide.aet.proxy.RestProxyManager.cfg` file - default config for Vagrant is:
```
server=192.168.123.100
port=8080
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#
# AET
#
# Copyright (C) 2013 Cognifide Limited
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

server=192.168.123.100
port=8080