Feature/inconsistent screenshot height #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakub-Izbicki
force-pushed
the
feature/inconsistent-screenshot-height
branch
from
e362351
to
dac9662
Compare
plutasnyy
approved these changes
Oct 16, 2018
tkaik
reviewed
Oct 17, 2018
core/jobs/src/main/java/com/cognifide/aet/job/common/utils/Sampler.java
Outdated
Show resolved
Hide resolved
tkaik
reviewed
Oct 18, 2018
| */ | ||
| public static <T> T waitForValue(Supplier<T> samplesSupplier, int samplingPeriod, | ||
| int sampleQueueSize, int maxSamplesThreshold) { | ||
| LinkedList<T> samplesQueue = new LinkedList<>(); |
There was a problem hiding this comment.
Did you consider using org.apache.commons.collections.buffer.CircularFifoBuffer ? I think you can use it here to simplify your code :)
There was a problem hiding this comment.
Great suggestion! I have updated the code.
Jakub-Izbicki
force-pushed
the
feature/inconsistent-screenshot-height
branch
2 times, most recently
from
3c32a98
to
f096cfc
Compare
Jakub-Izbicki
force-pushed
the
feature/inconsistent-screenshot-height
branch
from
f096cfc
to
675de4c
Compare
|
Tested, OK! |
tkaik
approved these changes
Oct 23, 2018
malaskowski
reviewed
Oct 23, 2018
...jobs/src/main/java/com/cognifide/aet/job/common/modifiers/resolution/ResolutionModifier.java
Outdated
Show resolved
Hide resolved
| .checkRange(height, 1, MAX_SIZE, | ||
| "Height should be greater than 0 and smaller than " + MAX_SIZE); | ||
| } else { | ||
| samplingPeriod = Optional.ofNullable(params.get(SAMPLING_PERIOD_PARAM)) |
There was a problem hiding this comment.
There is no limit for the samplingPeriod.
Just a question here: shouldn't that be limited somehow?
What will happen if user sets here e.g. 10000000 ms?
There was a problem hiding this comment.
You are correct, there should be a range for this param. I will set max at 10 seconds. Please give suggestion if the value seems reasonable.
Jakub-Izbicki
force-pushed
the
feature/inconsistent-screenshot-height
branch
from
9efdd9c
to
16d944f
Compare
malaskowski
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add algorithm to enable taking long screenshots without resolution-sleep-resolution workaround.
Description
This is a proposed solution no. 2 from issue #357. An algorithm that takes samples of page height in defined periods of time.
Adds new param to
<screen/>calledsamplingPeriod, which defined waiting time between taking samples.Please give suggestions if all proposed default values in algorithm are ok, and if some of them should be configurable or not:
samplingPeriod- 100ms (configurable)Please note, this pr is supposed to be merged after #387. There are several todos in code that indicate the tests should be changed to test proper page heights.
Motivation and Context
Fixed #357
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.