Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant changes in test-suite partials from rerun milestone branch #444

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

tkaik
Copy link
Contributor

@tkaik tkaik commented Nov 27, 2018

Description

Re-run feature PR ( #412 ) commited some accidental changes in test-suite XML partials (those changes were probably meant to be temporary, for purposes of local tests). This PR reverts them

Screenshots (if appropriate)

Upgrade notes (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

@tkaik tkaik requested review from malaskowski and plutasnyy and removed request for malaskowski November 27, 2018 14:23
@tkaik
Copy link
Contributor Author

tkaik commented Nov 27, 2018

Note: partials for execute JS modifier and login modifier are already in partials-templates directory so I deleted the duplicates

@tkaik tkaik merged commit 8663f92 into master Nov 27, 2018
@tkaik tkaik deleted the revert-rerun-test-suite-changes branch November 27, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants