Add loggers in collector/modifier #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plutasnyy
reviewed
Jan 25, 2019
| @@ -48,7 +48,7 @@ public JavaScriptJobResult execute(String jsSnippet, Object... elements) | |||
|
|
|||
| private JavaScriptJobResult executeJs(String jsSnippet, Object... elements) { | |||
| if (LOGGER.isDebugEnabled()) { | |||
| LOGGER.debug("Executing JavaScript command: {} on page: {}", jsSnippet, currentUrl); | |||
| LOGGER.trace("Executing JavaScript command: {} on page: {}", jsSnippet, currentUrl); | |||
plutasnyy
reviewed
Jan 25, 2019
| final String html = jsExecutor.execute(DOCUMENT_OUTER_HTML_SCRIPT) | ||
| .getExecutionResultAsString(); | ||
| LOGGER.debug("Executing Accessibility Collector"); |
There was a problem hiding this comment.
Duplicate messages were on purpose?
...java/com/cognifide/aet/job/common/modifiers/executejavascript/ExecuteJavaScriptModifier.java
Outdated
Show resolved
Hide resolved
tkaik
approved these changes
Feb 5, 2019
plutasnyy
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made changes in loggers as suggested in #446
Description
Motivation and Context
Closes #446
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.