-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WebAPI issues #469
Fix WebAPI issues #469
Conversation
CHANGELOG.md
Outdated
@@ -25,6 +25,7 @@ All notable changes to AET will be documented in this file. | |||
- [PR-404](https://github.com/Cognifide/aet/pull/404) Added missing tooltip for conditional tests | |||
- [PR-408](https://github.com/Cognifide/aet/pull/408) Advanced Screen Comparision button layout fix | |||
- [PR-410](https://github.com/Cognifide/aet/pull/410) Notification that displays when exclude-elements are not found on page now shows what specific elements were not found([#372](https://github.com/Cognifide/aet/issues/372)) | |||
- [PR-469](https://github.com/Cognifide/aet/pull/469) Fix WebAPI issues([#425](https://github.com/Cognifide/aet/issues/425)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be in unreleased section
} else if (suiteName != null) { | ||
paramsValuesMessage = String.format("suite name: %s", suiteName); | ||
if (suiteVersion != null) { | ||
paramsValuesMessage = String.format("%s, version: %s", paramsValuesMessage, suiteVersion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is everything ok with formatting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, these are nested if statements. It's OK according to Google Style
Tested and accepted. QA Covered. |
I fixed some inconsistencies in WebAPI responses and provided more meaningful 404 messages.
Closes #425
Description
Issues addressed:
http://aet-vagrant:8181/api/artifact?company=company&project=project&id=99999999
500
404
http://aet-vagrant:8181/api/artifact?company=company&project=project&id=99999999
400
404
http://aet-vagrant:8181/api/metadata?company=company&project=project&suite=no_existing_suite
400
404
http://aet-vagrant:8181/api/metadata?company=company&project=project&suite=test-suite&version=999
400
404
http://aet-vagrant:8181/configs/locks
Motivation and Context
Closes #425
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.