add source pattern and collected date #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plutasnyy
approved these changes
Oct 15, 2019
KarolFrankiewicz
changed the title
dzuma
reviewed
Nov 12, 2019
| try { | ||
| stamp = artifactsDAO.getArtifactUploadDate(properties, properties.getPatternId()).getTime(); | ||
| } catch(Exception e) { | ||
| stamp = 0; |
There was a problem hiding this comment.
never loose exception log :)
tMaxx
requested changes
Aug 6, 2020
core/jobs/src/main/java/com/cognifide/aet/job/common/comparators/source/SourceComparator.java
Outdated
Show resolved
Hide resolved
tMaxx
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds dates for pattern and collected source in source comparator.
Description
User is able to see dates of collected and pattern sources just like it works right now for screenshots comparison
In case pattern date was not saved before, both dates won't be shown
Motivation and Context
feature required in #500
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.