Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using login modifier with only partial path #531

Merged
merged 3 commits into from
Aug 6, 2020

Conversation

malaskowski
Copy link
Contributor

Description

Currently, the login modifier requires passing the full login-page URL in the properties.

Motivation and Context

Passing full URL to the login page is sometimes difficult, especially when a single suite is reused among multiple domains.
This PR enables running login modifier with only part of the login page, and the full URL is built using domain (the same logic as url works).

Upgrade notes (if appropriate)

This feature is backward compatible. Proper updates were made in the wiki docs.
The logic behind the change is:

  • if the login-page starts with http prefix, then the old logic is triggered (full login page URL)
  • otherwise, login-page is treated as a path, and domain is added in the front (see unit tests for details).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

@tMaxx tMaxx merged commit 337c665 into master Aug 6, 2020
@tMaxx tMaxx deleted the feature/login-modifier-with-login-page-path branch August 6, 2020 14:09
@annabudziszewska
Copy link
Collaborator

annabudziszewska commented Oct 27, 2020

Tested and accepted
version: 3.3.1.SNAPSHOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants