Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition under non-native bash environments #554

Merged
merged 2 commits into from
May 18, 2020

Conversation

tMaxx
Copy link
Collaborator

@tMaxx tMaxx commented May 18, 2020

Description

Force treating body as string. Under non-native (e.g. cygwin, mingw) bash environments this may cause a race condition when checking suite status, resulting in a timeout and a 404 that gets passed to user.

Motivation and Context

Fixes #551.

Upgrade notes (if appropriate)

Manual upgrade of aet.sh will be required.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

@malaskowski
Copy link
Contributor

Please update CHANGELOG.

@tMaxx tMaxx merged commit ab49f46 into master May 18, 2020
@tMaxx tMaxx deleted the bugfix/551-fix-failure-under-mingw branch August 6, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AET run failed on "element not found before timeout"
2 participants