Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Issues Provider #564

Merged
merged 14 commits into from
Aug 12, 2020
Merged

Conversation

tMaxx
Copy link
Collaborator

@tMaxx tMaxx commented Jul 1, 2020

Implementation of #557

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

Copy link
Contributor

@tkaik tkaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide some documentation for this features as well - How to use it from AET user perspective (i.e. report) etc.

Please also update the CHANGELOG.md file with info about this PR

@tMaxx tMaxx marked this pull request as ready for review August 4, 2020 17:47
@tMaxx tMaxx requested a review from tkaik August 4, 2020 17:50
@tMaxx tMaxx merged commit 82b0b52 into master Aug 12, 2020
@tMaxx tMaxx deleted the feature/accessibility-report-integration branch August 12, 2020 09:04

URL is as follows:

`<domain>/api/accessibility/report?company=<company>&project=<project>&suite=<suite>&correlationId=<correlationId>&type=<type>&extension=<type>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'type' should be replaced by 'verbosity'

Where:
- `domain`: domain on which AETs are set up (eg. `localhost`)
- `company`, `project`, `suite`, `correlationId`: for these the report will be generated, if available
- `verbosity`: verbosity level of the report, comma separated values: `NOTICE`, `WARNING`, `ERROR` (case-insensitive; e.g.: `notice,error`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING is not working (it's 'WARN' instead) so documentation should be adjusted or implementation changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants