-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add three extensions for JsonToKotlinClass plugin #349
Conversation
Signed-off-by: yuanzicong <[email protected]>
Signed-off-by: yuanzicong <[email protected]>
@varenyzc Greate! Amazing me, you do these so fast 😱 Also we need unit test for each new feature. Please make up the test cases. Thank you 😁 Can ref: src/test/kotlin/extensions/nstd/ReplaceConstructorParametersByMemberVariablesSupportTest.kt |
@wuseal okay,i will make it tomorrow😁 |
Signed-off-by: yuanzicong <[email protected]>
@wuseal I have completed the test case. Should I make a new pull request? |
@varenyzc No need, You could just push your test cases to branch varenyzc:master is OK |
src/main/kotlin/extensions/yuan/varenyzc/BuildFromJsonObjectSupport.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/extensions/yuan/varenyzc/NeedNonNullableClassesSupport.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: yuanzicong <[email protected]>
@varenyzc Well done! Thanks very much that you provided these awesome features for JTK👏👏👏👏👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wuseal This is my first time to make a PR for open source project.Thanks for your review! |
Published in 3.7.1-EAP-3 |
Add three extensions for JsonToKotlinClass plugin
CamelCaseSupport: It can type camel-case property.
BuildFromJsonSupport : It can type a companion object with a function what can build from json.
NeedNonNullableClassesSupport: It can make the classes that you type in the extensions input area non nullabe.