Add three extensions for JsonToKotlinClass plugin #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2021 15:30
Signed-off-by: yuanzicong <[email protected]>
Signed-off-by: yuanzicong <[email protected]>
|
@varenyzc Greate! Amazing me, you do these so fast 😱 Also we need unit test for each new feature. Please make up the test cases. Thank you 😁 Can ref: src/test/kotlin/extensions/nstd/ReplaceConstructorParametersByMemberVariablesSupportTest.kt |
|
@wuseal okay，i will make it tomorrow😁 |
Signed-off-by: yuanzicong <[email protected]>
|
@wuseal I have completed the test case. Should I make a new pull request? |
|
@varenyzc No need, You could just push your test cases to branch varenyzc:master is OK |
wuseal
reviewed
May 20, 2021
src/main/kotlin/extensions/yuan/varenyzc/BuildFromJsonObjectSupport.kt
Outdated
Show resolved
Hide resolved
wuseal
reviewed
May 20, 2021
wuseal
reviewed
May 20, 2021
src/main/kotlin/extensions/yuan/varenyzc/NeedNonNullableClassesSupport.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: yuanzicong <[email protected]>
|
@varenyzc Well done! Thanks very much that you provided these awesome features for JTK👏👏👏👏👍 |
wuseal
added
awesome pull request
|
@wuseal This is my first time to make a PR for open source project.Thanks for your review！ |
|
Published in 3.7.1-EAP-3 |
This was referenced May 26, 2021
wuseal
added a commit
that referenced
this pull request
Sep 20, 2021
Add three extensions for JsonToKotlinClass plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CamelCaseSupport: It can type camel-case property.
BuildFromJsonSupport : It can type a companion object with a function what can build from json.
NeedNonNullableClassesSupport: It can make the classes that you type in the extensions input area non nullabe.