Do not assume that assertions are enabled #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to access `self._scenes_cache` only works after `self.scenes()`
has been invoked. Normally, the previous line of code (`assert
scene_name in self.scenes()`) would cause an invocation of
`self.scenes()` (and thereby populate `self._scenes_cache`), but that
doesn't actually happen if assertions are disabled!
Before this change
==================
$ PYTHONOPTIMIZE=1 python -c 'import rxv; rxv.RXV("http://receiver/YamahaRemoteControl/ctrl").scene = "BD/DVD"; print("success!")'
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/home/jeremy/src/github.com/wuub/rxv/rxv/rxv.py", line 457, in scene
scene_number = self._scenes_cache.get(scene_name)
AttributeError: 'NoneType' object has no attribute 'get'
After this change
=================
$ PYTHONOPTIMIZE=1 python -c 'import rxv; rxv.RXV("http://receiver/YamahaRemoteControl/ctrl").scene = "BD/DVD"; print("success!")'
success!
|
@wuub any chance of getting this merged up? |
|
@wuub quick ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to access
self._scenes_cacheonly works afterself.scenes()has been invoked. Normally, the previous line of code (
assert scene_name in self.scenes()) would cause an invocation ofself.scenes()(and thereby populateself._scenes_cache), but thatdoesn't actually happen if assertions are disabled!
Before this change
After this change