Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper teardown on Ctrl-C #3

Closed
wvengen opened this issue Jun 22, 2021 · 0 comments
Closed

Proper teardown on Ctrl-C #3

wvengen opened this issue Jun 22, 2021 · 0 comments

Comments

@wvengen
Copy link
Owner

wvengen commented Jun 22, 2021

RMididings is often terminated using Ctrl-C, but this does not run any clean-up code. This will become especially important with things like hooks that would need a teardown (e.g. OSC unregistering).

The ctrlc crate doesn't work here, because we use polling fds - Detegr/rust-ctrlc#30 (comment) is would probably be necessary.
wvengen added a commit that referenced this issue Jul 2, 2021
@wvengen
Teardown on Ctrl-C (#3)
6ef3b11 
Also improves performance by only calling these backends that have
events waiting when new events arrive.
@wvengen wvengen closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wvengen