Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skani shuffle #39

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fix skani shuffle #39

merged 4 commits into from
Nov 29, 2023

Conversation

AroneyS
Copy link
Collaborator

@AroneyS AroneyS commented Nov 29, 2023

No description provided.

@AroneyS
Copy link
Collaborator Author

AroneyS commented Nov 29, 2023

I get this error on real-world use.

thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', src/skani.rs:78:99

@AroneyS
Copy link
Collaborator Author

AroneyS commented Nov 29, 2023

@wwood my real-world test works now. I spot-checked all the genomes from the weird cluster I found and they are all in individual clusters now.

@AroneyS AroneyS marked this pull request as ready for review November 29, 2023 23:08
@AroneyS AroneyS requested a review from wwood November 29, 2023 23:09
@wwood wwood merged commit f199654 into main Nov 29, 2023
2 checks passed
@wwood
Copy link
Owner

wwood commented Nov 29, 2023

Thanks. I guess now working out which index is which requires iteration of the whole array? Can you please make a hash lookup? Presumably fastera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants