-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSVC build environment. #2085
Closed
Closed
MSVC build environment. #2085
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9567b29
Fixes MSVC build environment
kdschlosser d4041c3
Adds additional bash.exe source.
kdschlosser 16d65de
Adds dependency link for comtypes.
kdschlosser fb47e01
Fixes issue with BSTR not being the proper size on x86
kdschlosser 6151ae0
moves comtypes install to devel.txt
kdschlosser 72bd325
Trying to solve issue with BSTR
kdschlosser 1933e23
fixes exception catching for GetDisplayName
kdschlosser 4fa55bb
fixes GetDescription and GetDisplayName
kdschlosser 087c2d4
Removes dependence on comtypes
kdschlosser cb7eb70
Fixes some environment settings
kdschlosser 8c637d8
adds debugging output for msvc environment
kdschlosser 938cc84
fixes path in msvc environment
kdschlosser 868f158
Speeds up Windows build
kdschlosser dc6edc1
fixes msvc environment path so the already stet path is added to the …
kdschlosser e88f175
See if this fixes the missing include folder.
kdschlosser c4c805b
sets the msvc environment into a global so it doesn't get run more th…
kdschlosser 519196e
Hopefully I have it fixed now!!
kdschlosser ad4aa60
Fixes formatting error
kdschlosser a61ef61
Fixes Windows ninja compilation
kdschlosser 0be5301
Fixes issue with WSL and removes use of CMAKE and Ninja
kdschlosser af5ecbe
adds doing a complete build in setup.py
kdschlosser a5e4390
adds pyproject.toml
kdschlosser cfe21f9
removes msvc from buildtools and grabs pyMSVC from pypi
kdschlosser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can do:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I cannot.
because if cmake or ninja is not available then cmake.exe doesn't get set to the nmake command so if the platform is windows we do not want to ad a --jobs to the nmake.exe command bcause it doesn't support this switch.