Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix discriminator bug in recursive type #596

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: fix discriminator bug in recursive type #596

merged 1 commit into from
Oct 18, 2023

Conversation

wyfo
Copy link
Owner

@wyfo wyfo commented Oct 18, 2023

Fixes #567
By the way, discriminator feature will be reworked in next version, and the current API will be deprecated

@codecov-commenter
Copy link

Codecov Report

Merging #596 (b431d22) into master (e4652c8) will decrease coverage by 0.07%.
Report is 2 commits behind head on master.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   88.00%   87.93%   -0.07%     
==========================================
  Files          62       62              
  Lines        5677     5687      +10     
  Branches     1240     1244       +4     
==========================================
+ Hits         4996     5001       +5     
- Misses        470      472       +2     
- Partials      211      214       +3     
Files Coverage Δ
apischema/deserialization/__init__.py 99.64% <100.00%> (-0.02%) ⬇️
apischema/deserialization/methods.py 85.02% <64.28%> (-0.29%) ⬇️

Fixes #567
By the way, discriminator feature will be reworked in next version,
and the current API will be deprecated
@wyfo wyfo merged commit c4755d5 into master Oct 18, 2023
8 of 9 checks passed
@wyfo wyfo deleted the issue_567 branch October 18, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discriminator and recursive fields
2 participants