iOS bug fix: scaling sometimes resulted in "white lines" on the right and/or bottom of the output image #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(ex: 1500x1001 pixel image gets a white line on the bottom)
|
Can you guys merge this? My app is suffering from this bug. |
andersdn
added a commit
to andersdn/cordova-imagePicker
that referenced
this pull request
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where some images got a white line on the right or bottom after scaling.
For example, if the input image is a 1500x1001 pixels, the output has a white line on the bottom. Easy to see if the source image is dark / all black.
I didn't look at the other platforms. They may have the same bug.