Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Tag Manager option #324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nnagewad
Copy link

@nnagewad nnagewad commented Sep 6, 2024

This is a proposal to add Google Tag Manager to XGOV's Eleventy plugin.

This requires updating the base.njk layout by adding a conditional statement on whether a Google Tag Manager identifier is added via eleventy.config.js file.

@paulrobertlloyd
Copy link
Collaborator

Hmmm, this makes me very uneasy. There’s nothing worse than injecting somebody else’s JavaScript into a webpage… except perhaps Google’s JavaScript.

Appreciate the need, but in my opinion, some things should be difficult to achieve, and injecting third-party scripts is right up there on that list.

Making it easier to extend templates will be the way forward for making such changes, I think. I’ll start looking into how that may work soon.

In the meantime, maybe there are other ways we can enable extending the base template?

@paulrobertlloyd paulrobertlloyd changed the title Add Google Tag Manager to XGOV Eleventy plugin Add Google Tag Manager option Sep 21, 2024
@paulrobertlloyd paulrobertlloyd added the enhancement New feature or request label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants