Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove needless deref & borrow #37

Merged
merged 3 commits into from
Sep 3, 2022
Merged

Remove needless deref & borrow #37

merged 3 commits into from
Sep 3, 2022

Conversation

x7c1
Copy link
Owner

@x7c1 x7c1 commented Sep 3, 2022

error: deref on an immutable reference
  --> libs/gesha-core/src/conversions/v3_0/to_rust_type/post_processor/resolve_ref.rs:83:69
   |
83 |                 DataType::Vec(Box::new(self.type_shape_to_data_type(&*type_shape)?))
   |                                                                     ^^^^^^^^^^^^
   |
   = note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
help: if you would like to reborrow, try removing `&*`
   |
83 |                 DataType::Vec(Box::new(self.type_shape_to_data_type(type_shape)?))
   |                                                                     ~~~~~~~~~~
help: if you would like to deref, try using `&**`
   |
83 |                 DataType::Vec(Box::new(self.type_shape_to_data_type(&**type_shape)?))
   |                                                                     ~~~~~~~~~~~~~

cargo clippy -- --no-deps -D warnings
cargo clippy -- \
--no-deps \
--allow clippy::derive_partial_eq_without_eq \
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason to accept this lint.
waiting for derive_partial_eq_without_eq to be removed from the default rule.

rf. rust-lang/rust-clippy#9063

@x7c1 x7c1 merged commit 37d46c7 into main Sep 3, 2022
@x7c1 x7c1 deleted the 2022-09-03-clippy branch September 3, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant