fix: Strips HTML from quiz names to fix #439. (#446 - Thanks @garemoko)

xAPI-vle · Feb 21, 2019 · 5853986 · 5853986
1 parent f6b6c8d
commit 5853986
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/src/transformer/events/mod_quiz/question_answered/essay.php b/src/transformer/events/mod_quiz/question_answered/essay.php
@@ -42,7 +42,7 @@ function essay(array $config, \stdClass $event, \stdClass $questionattempt, \std
             'definition' => [
                 'type' => 'http://adlnet.gov/expapi/activities/cmi.interaction',
                 'name' => [
-                    $lang => $question->questiontext,
+                    $lang => utils\get_string_html_removed($question->questiontext)
                 ],
                 'interactionType' => 'long-fill-in',
             ]

diff --git a/src/transformer/events/mod_quiz/question_answered/gapselect.php b/src/transformer/events/mod_quiz/question_answered/gapselect.php
@@ -43,7 +43,7 @@ function gapselect(array $config, \stdClass $event, \stdClass $questionattempt,
             'definition' => [
                 'type' => 'http://adlnet.gov/expapi/activities/cmi.interaction',
                 'name' => [
-                    $lang => $question->questiontext,
+                    $lang => utils\get_string_html_removed($question->questiontext)
                 ],
                 'interactionType' => 'sequencing',
             ]

diff --git a/src/transformer/events/mod_quiz/question_answered/match.php b/src/transformer/events/mod_quiz/question_answered/match.php
@@ -53,7 +53,7 @@ function ($reduction, $selection) {
             'definition' => [
                 'type' => 'http://adlnet.gov/expapi/activities/cmi.interaction',
                 'name' => [
-                    $lang => $question->questiontext,
+                    $lang => utils\get_string_html_removed($question->questiontext)
                 ],
                 'interactionType' => 'matching',
             ]

diff --git a/src/transformer/events/mod_quiz/question_answered/numerical.php b/src/transformer/events/mod_quiz/question_answered/numerical.php
@@ -42,7 +42,7 @@ function numerical(array $config, \stdClass $event, \stdClass $questionattempt,
             'definition' => [
                 'type' => 'http://adlnet.gov/expapi/activities/cmi.interaction',
                 'name' => [
-                    $lang => $question->questiontext,
+                    $lang => utils\get_string_html_removed($question->questiontext)
                 ],
                 'interactionType' => 'numeric',
             ]

diff --git a/src/transformer/events/mod_quiz/question_answered/randomsamatch.php b/src/transformer/events/mod_quiz/question_answered/randomsamatch.php
@@ -53,7 +53,7 @@ function ($reduction, $selection) {
             'definition' => [
                 'type' => 'http://adlnet.gov/expapi/activities/cmi.interaction',
                 'name' => [
-                    $lang => $question->questiontext,
+                    $lang => utils\get_string_html_removed($question->questiontext)
                 ],
                 'interactionType' => 'matching',
             ]

diff --git a/src/transformer/events/mod_quiz/question_answered/shortanswer.php b/src/transformer/events/mod_quiz/question_answered/shortanswer.php
@@ -42,7 +42,7 @@ function shortanswer(array $config, \stdClass $event, \stdClass $questionattempt
             'definition' => [
                 'type' => 'http://adlnet.gov/expapi/activities/cmi.interaction',
                 'name' => [
-                    $lang => $question->questiontext,
+                    $lang => utils\get_string_html_removed($question->questiontext)
                 ],
                 'interactionType' => 'fill-in',
             ]

diff --git a/tests/mod_quiz/attempt_submitted/gapselect/statements.json b/tests/mod_quiz/attempt_submitted/gapselect/statements.json
@@ -110,7 +110,7 @@
             "definition": {
                 "type": "http:\/\/adlnet.gov\/expapi\/activities\/cmi.interaction",
                 "name": {
-                    "en": "<p>Example [[1]] missing [[2]] words [[3]]<\/p>"
+                    "en": "Example [[1]] missing [[2]] words [[3]]"
                 },
                 "interactionType": "sequencing"
             }

diff --git a/tests/mod_quiz/attempt_submitted/randomsamatch/statements.json b/tests/mod_quiz/attempt_submitted/randomsamatch/statements.json
@@ -110,7 +110,7 @@
             "definition": {
                 "type": "http:\/\/adlnet.gov\/expapi\/activities\/cmi.interaction",
                 "name": {
-                    "en": "<p>Example Random short-answer matching question<br><\/p>"
+                    "en": "Example Random short-answer matching question"
                 },
                 "interactionType": "matching"
             }