Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moodle proxy setting not used #238

Closed
peterspicer-catalyst opened this issue Aug 31, 2018 · 2 comments
Closed

Moodle proxy setting not used #238

peterspicer-catalyst opened this issue Aug 31, 2018 · 2 comments
Assignees
@ryasmi
Labels
fix

Comments

@peterspicer-catalyst
Copy link

Description

  • If the Moodle installation is behind a proxy server, sending statements to an LRS will fail.

Version

  • observed in 3.14.1 and 3.16.0

Steps to reproduce the bug

  1. Have a proxy configured in $CFG->proxyhost (and possibly $CFG->proxyport).
  2. Nothing will be sent as the sent_http_statements function doesn't pass any proxy details to cURL so nothing can be sent.

Additional information

  • This was previously raised as issue Moodle PROXY setting not used #84 and was implemented at least through the 2.x series. I suspect it has been problematic since the major refactoring that debuted in 3.0.0.
@ryasmi
Copy link
Member

ryasmi commented Aug 31, 2018

Hey @peterspicer-catalyst, good to see you back here, hope you're well. Thanks for reporting this, you're absolutely correct, 3.0.0 regressed regarding this particular issue. Will investigate how this can be resolved now.

@ryasmi ryasmi added the fix label Aug 31, 2018
@ryasmi ryasmi self-assigned this Aug 31, 2018
This was referenced Aug 31, 2018
Closed
Merged
ryasmi added a commit that referenced this issue Sep 3, 2018
@ryasmi
Merge pull request #241 from xAPI-vle/fix-proxy-moodlecurl
b066189 
feat: Adds moodle_curl_lrs loader to close #238
@ryasmi ryasmi mentioned this issue Sep 3, 2018
Merged
ryasmi added a commit that referenced this issue Sep 3, 2018
@ryasmi
feat: Adds moodle_curl_lrs loader to close #238 (#242)
3da6e75
@HT2Bot
Copy link
Member

HT2Bot commented Sep 3, 2018

🎉 This issue has been resolved in version 3.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryasmi ryasmi

Labels
fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ryasmi @HT2Bot @peterspicer-catalyst