feat: Adds id number in object extension for courses and activities to close #230. #272
Conversation
…ses and activities to close xAPI-vle#230.
| } | ||
|
|
||
| if (utils\is_enabled_config($config, 'send_course_and_module_idnumber')) { | ||
| $courseidnumber = property_exists($course, 'idnumber') ? $course->idnumber : null; |
There was a problem hiding this comment.
@davidpesce wonder if we should have the same check for shortname above, but probably ok.
| ], | ||
| ]; | ||
|
|
||
| if (utils\is_enabled_config($config, 'send_short_course_id')) { |
There was a problem hiding this comment.
Usually prefer to avoid mutations because it becomes quite hard to read as the size of the code grows, but that is quite painful in PHP (usually work in JS where this is easier to avoid). Happy with this though, just thought I'd explain why it wasn't like that before, just a personal habit.
There was a problem hiding this comment.
I prefer to avoid doing it this way too and it's definitely won't be suitable as the codebase grows.
Handling extensions moving forward will probably need to be split off into its own utils. This will allow for much easier additions and allow the possibility for custom extension names to be set in the config area. As I think the extension names are too specific but making them more generic would just be confusing.
| @@ -77,6 +77,7 @@ protected function get_transformer_config() { | |||
| 'send_mbox' => false, | |||
| 'send_response_choices' => false, | |||
| 'send_short_course_id' => false, | |||
| 'send_course_and_module_idnumber' => false, | |||
There was a problem hiding this comment.
@davidpesce this reminds me that we should probably have some tests that check these config values still work in the plugin when they're enabled.
|
🎉 This PR is included in version 3.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thanks @ryansmith94. I'm hoping to be able to contribute more. |
|
You're welcome @trewq, that'd be awesome if you can 👍 |
Description
Adds id number in object extension for courses and activities under the extension
https://w3id.org/learning-analytics/learning-management-system/external-id.There is a config option (disabled by default) for this extension to keep consistency with the shortid extension.
Related Issues
Related issue #230
PR Type
Enhancement