feat(JISC): Adds jisc extensions behind send_jisc_data setting.

[ryasmi]

Description
Adds jisc extensions behind send_jisc_data setting.

{
  "http://xapi.jisc.ac.uk/sessionId": "sesskey()",
  "http://id.tincanapi.com/extension/ip-address": "$event->ip",
  "http://xapi.jisc.ac.uk/courseArea": {
    "http://xapi.jisc.ac.uk/vle_mod_id": "$course->shortname"
  },
  "http://xapi.jisc.ac.uk/statementCat": "VLE"
}

Related Issues

• Resolves Add JISC context extensions to statements. #422

PR Type

• Enhancement

[ryasmi]

@garemoko / @davidpesce you guys happy with this?

[davidpesce]

I think this looks good. The only concern that I'm remembering is with the session key. It looks like you made it unique by including the base URL for JISC's platform as the first part, then appended the sessionId.

I'm not sure where we landed on whether the sessionIds could be re-used (or collisions occurring). But with it being in an extension I don't see any technical concerns.

[ryasmi]

I think the collisions are ok, I think it can be combined with other values to make it more unique.

[ryasmi]

Thanks for taking a look @davidpesce 👍

[HT2Bot]

🎉 This PR is included in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀