Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] time type conversion to timedelta if timedelta64 is given #660

Merged
merged 6 commits into from
Jun 10, 2024
Merged

[PR] time type conversion to timedelta if timedelta64 is given #660

merged 6 commits into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. make sure time diff type is timedelta: in case it was timedelta64 con… 

    …vert it, so following `.seconds` line could run without error
    @lee1043 @tomvothecoder
    lee1043 authored and tomvothecoder committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    69c1a29 View commit details
    Browse the repository at this point in the history

  2. Update xcdat/bounds.py 

    Co-authored-by: Stephen Po-Chedley <[email protected]>
    @lee1043 @pochedls @tomvothecoder
    2 people authored and tomvothecoder committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a60007f View commit details
    Browse the repository at this point in the history

  3. proceed pd.to_timedelta only if diff type is np.timedelta64

    @lee1043 @tomvothecoder
    lee1043 authored and tomvothecoder committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c019318 View commit details
    Browse the repository at this point in the history

  4. Update _create_time_bounds() 

    - Add comment about needing to convert dype=timedelta64[ns] to pandas timedelta object
- Ignore C901 flake8 error
    @tomvothecoder
    tomvothecoder committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    09203f2 View commit details
    Browse the repository at this point in the history

  5. Add coverage for new code

    @tomvothecoder
    tomvothecoder committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c6b314a View commit details
    Browse the repository at this point in the history

  6. Update tests/test_bounds.py

    @tomvothecoder
    tomvothecoder committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    189e526 View commit details
    Browse the repository at this point in the history