-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Brush Pegan test #102
Add Brush Pegan test #102
Conversation
@sourish-cmi Do we need to add any getters? If so, which? |
@ShouvikGhosh2048 I think if you add |
Add functional testing. julia> pvalue(BP_tst) = 0.46203539153321815 |
@sourish-cmi I've added the getters. |
Okay I got the error with confint Then I looked into source code of It looks like they have created a place holder for I will ask them but for now lets drop the idea of |
All looks good. Did you add a functional test. We will need one when we will do a release for version 0.1.1 |
@sourish-cmi |
@ShouvikGhosh2048 - yes you are correct. This is only for the Linear Regression model. In my PhD thesis, I wrote a function about extracting residual for Logistic Regression and others. We can make them available. It is not very difficult. It is just a few lines of code. Anyway, for now, I think if we can add document and functional testing and we can close this PR |
I've added the docs and tests. |
No description provided.