Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brush Pegan test #102

Merged
merged 4 commits into from
Feb 18, 2023
Merged

Conversation

ShouvikGhosh2048
Copy link
Collaborator

No description provided.

@ShouvikGhosh2048
Copy link
Collaborator Author

@sourish-cmi
I've added BPTest, but I haven't added any getters from HypothesisTests, like pvalue, so those won't work without importing HypothesisTests.

Do we need to add any getters? If so, which?

@sourish-cmi
Copy link
Collaborator

@sourish-cmi I've added BPTest, but I haven't added any getters from HypothesisTests, like pvalue, so those won't work without importing HypothesisTests.

Do we need to add any getters? If so, which?

@ShouvikGhosh2048 I think if you add pvalue and confint would be good enough.

@sourish-cmi sourish-cmi added the enhancement New feature or request label Feb 16, 2023
@sourish-cmi sourish-cmi linked an issue Feb 16, 2023 that may be closed by this pull request
@sourish-cmi
Copy link
Collaborator

Add functional testing.

julia> pvalue(BP_tst) = 0.46203539153321815

@ShouvikGhosh2048
Copy link
Collaborator Author

@sourish-cmi I've added the getters.
Could you try using confint with the bptest?

@sourish-cmi
Copy link
Collaborator

Could you try using confint with the bptest?

Okay I got the error with confint

Then I looked into source code of HypothesisTests.jl - here:

It looks like they have created a place holder for confint - but it is not implemented.

I will ask them but for now lets drop the idea of confint. Lets just implement the pvalue.

@sourish-cmi
Copy link
Collaborator

All looks good. Did you add a functional test. We will need one when we will do a release for version 0.1.1

@ShouvikGhosh2048
Copy link
Collaborator Author

@sourish-cmi
The residuals function doesn't work for logistic regression models. Is this test only for Linear Regression models?

@sourish-cmi
Copy link
Collaborator

@sourish-cmi The residuals function doesn't work for logistic regression models. Is this test only for Linear Regression models?

@ShouvikGhosh2048 - yes you are correct. This is only for the Linear Regression model. In my PhD thesis, I wrote a function about extracting residual for Logistic Regression and others. We can make them available. It is not very difficult. It is just a few lines of code.

Anyway, for now, I think if we can add document and functional testing and we can close this PR

@ShouvikGhosh2048
Copy link
Collaborator Author

I've added the docs and tests.

@sourish-cmi sourish-cmi merged commit 33b5780 into xKDR:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Brush-Pegan test for checking heteroskedasticity
2 participants