Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistency checks to expensive operations #29

Open
chiraganand opened this issue May 2, 2022 · 0 comments
Open

Add consistency checks to expensive operations #29

chiraganand opened this issue May 2, 2022 · 0 comments

Comments

@chiraganand
Copy link
Member

chiraganand commented May 2, 2022

Since the TS object can be manipulated externally we need to perform consistency checks to make sure certain conditions are not violated before any expensive operation (such as apply(), rollapply(), or even print()).

Conditions which should be checked:

  1. The index should always be sorted.
  2. Duplicate values in the index should be checked if the object doesn't support them. Whether the object supports duplicate values or not can be stored inside some sort of a metadata object without touching the TS struct. This is until DataFrames.jl starts supporting metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant