-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to not copy columns when constructing a TSFrame #142
Conversation
This allows the user to tell TSFrames whether they want the columns of the input to be copied or not. With this and `issorted`, one can construct a TSFrame with almost no overhead. This feature is required for the join functions to have performance comparable to R.
Huh! It looks like something changed the sort order for the columns. Ideally we should be using |
This shouldn't be a problem. PS: Avoid force-pushing because it breaks code coverage and creates problems while merging the branch into |
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 91.41% 91.39% -0.02%
==========================================
Files 20 20
Lines 431 430 -1
==========================================
- Hits 394 393 -1
Misses 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bump @chiraganand - I think this should be mergeable now. |
Needs tests. Basically, this allows us to construct a TSFrame with negligible overhead.
It's based off asinghvi17:issorted, so once that's merged I'll rebase this.