Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Container.sol ERC-4337 compliant #27

Merged
merged 12 commits into from
Oct 31, 2024
Merged

Conversation

gabrielstoica
Copy link
Collaborator

@gabrielstoica gabrielstoica commented Oct 21, 2024

Breaking changes

  • Made Container ERC-4337 compliant by inheriting the Thirdweb non-upgradeable AccountCore implementation;
  • Removed upgradeability from the DockRegistry contract to comply with the BaseAccountFactory pattern;
  • Updated DockRegistry to act as a ERC-4337 factory allowing smart accounts to easily be created through the createAccount method. As before, at the creation time, each Container goes under one dock space. This method is also responsible to enable the initial modules on the smart account;

Other changes

  • Added a new executeBatch method on the Container smart account allowing for multiple module calls to be made within the same transaction;
  • Updated tests to match the new structure;
  • Refactored DeployDeterministicDockRegistry and DeployContainer scripts;

Copy link
Contributor

@V1d0r V1d0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gabrielstoica gabrielstoica merged commit f8ba449 into main Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants