Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address dynamic resizing of iframes on ipython #123

Merged

Conversation

krishnanand5
Copy link
Collaborator

Description

This PR includes changes for removing overflow on iframes and resizing them according to content of the plot.

Type of Change

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Pull Request

Description

This PR introduces JavaScript based changes to the generated iframe. We strictly remove overflow and scrolling for the plot that is maidr active and attach event listeners to find out the onFocus element. The major overflow happens when braille is activated. To address that, we have attached an onfocus event listener to the braille-div container and decide if we need to expand size of the iframe to accommodate for the additional space at the top.

This PR includes all changes made by @dakshpokar in his recent draft PR along with the Shiny specific changes I have made.

Checklist

  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code and ensured it follows the project's coding standards.
  • I have tested the changes locally following ManualTestingProcess.md, and all tests related to this pull request pass.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if applicable.
  • I have added appropriate unit tests, if applicable.

Copy link
Member

@jooyoungseo jooyoungseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jooyoungseo jooyoungseo merged commit 3159fc1 into xability:main Oct 17, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants