fix: address dynamic resizing of iframes on ipython #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes for removing overflow on iframes and resizing them according to content of the plot.
Type of Change
Checklist
Pull Request
Description
This PR introduces JavaScript based changes to the generated iframe. We strictly remove overflow and scrolling for the plot that is maidr active and attach event listeners to find out the onFocus element. The major overflow happens when braille is activated. To address that, we have attached an onfocus event listener to the
braille-div
container and decide if we need to expand size of the iframe to accommodate for the additional space at the top.This PR includes all changes made by @dakshpokar in his recent draft PR along with the Shiny specific changes I have made.
Checklist
ManualTestingProcess.md
, and all tests related to this pull request pass.