Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use htmltools instead of str #33

Merged
merged 3 commits into from
Apr 12, 2024
Merged

feat: use htmltools instead of str #33

merged 3 commits into from
Apr 12, 2024

Conversation

SaaiVenkat
Copy link
Collaborator

Maidr object has been modified to reflect HTMLDocument of htmltools. Users can use this to render the html or save as a string to a file.

Copy link
Member

@jooyoungseo jooyoungseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaaiVenkat As far as I recall, htmltools object has .show() method that opens the current html object in user's default browser.

  1. Please test whether this method works for maidr object now.

  2. If that works, please use that method instead of file save in all the examples.

@SaaiVenkat
Copy link
Collaborator Author

@SaaiVenkat As far as I recall, htmltools object has .show() method that opens the current html object in user's default browser.

  1. Please test whether this method works for maidr object now.
  2. If that works, please use that method instead of file save in all the examples.
  1. I have updated Maidr object to use HTML Tools with show(). However, this might be working only in the interactive session because of the HTTP server being closed when using scripts.

  2. Since they are examples, I have kept both save_html() as well as show().

Copy link
Member

@jooyoungseo jooyoungseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jooyoungseo jooyoungseo merged commit 8b0a838 into xability:main Apr 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants