Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BadgedTabbedPageRenderer.cs #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndastur
Copy link

@ndastur ndastur commented May 26, 2017

Saves users of the nuget package having to make source changes

@xabre
Copy link
Owner

xabre commented Jun 27, 2017

Hi, @ndastur thanks for the PR. Actually I had this in the beginning and it worked fine, except for one case: when the user had his own custom renderer and wanted to inherit from the badge renderer. The order in which XF registers renderers is somewhat unclear and I had the case where the rendere registered in the plugin overrode the app specific custom renderer. I don't want to merge these PRs until we can confirm that this is not an issue.

@ndastur
Copy link
Author

ndastur commented Jun 28, 2017

That's really interesting. I believe "most" plugins do use the technique in the pull requests on the basis that I haven't come across any other plugins that require that sort of manual intervention. I also think that the majority of users just want to "use" the plugin and what you describe is a real edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants