update hashbrown to v0.15 #314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should be split up - #10 is no longer valid and thus I have removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashbrown removed the RawTable API, requiring dashmap to use
HashTableinstead. This was the API I wanted dashmap 6 to use initially as the shards being RawTable means unsafe is often necessary.Due to needing some more RwLock mapping support when it comes to HashTable iterators and such, I designed the
RwLockReadGuardDetachedwhich cleans up a fair amount of pointer shenanigans around the codebase.In the process, I also decided to remove all the
unsafe impl Sendand make the RawRwLock guard be Send instead, as it seemingly is intended to be.miriwith both stacked and tree borrows seem happy still, and there's a lot less unsafe in the process.