Introduce new column property firstSortType #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- with firstSortType we introduce the possibility to controll the sort order on the first sort(e.g. first click on the <th>) for this column
|
Can this one be merged into master? |
p0psicles
pushed a commit
to p0psicles/vue-good-table
that referenced
this pull request
Jun 24, 2020
* Refactor sort module for readability * Add firstSortType property for columns - with firstSortType we introduce the possibility to controll the sort order on the first sort(e.g. first click on the <th>) for this column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the first sort on a column sorts always in ascending order. Sometimes the user expects the first sort to sort the data in descending order. For example in a table "Most visited pages", when sorting by visits (sessions, users ...) one would expect the default sort order to be descending.
With the introduced firstSortType column property this behavior can be achieved.
Notes: