Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with All in per page dropdown not staying selected #684

Merged
merged 8 commits into from
May 18, 2020

Conversation

jjmartucci
Copy link
Contributor

Addresses issue 676 #676

@jjmartucci
Copy link
Contributor Author

Hi @xaksis it looks like this is still an issue in the latest release, what would it take to get it out for the next one?

@xaksis
Copy link
Owner

xaksis commented May 11, 2020

ooh, thanks for pinging. I'll make sure it goes out in this weekend's release. Will review and let you know if there are any changes needed by Wed. Thank you for your patience, @jjmartucci!

@xaksis
Copy link
Owner

xaksis commented May 14, 2020

hey @jjmartucci could you please remove the built files from your PR. Just the source changes are fine.

@jjmartucci
Copy link
Contributor Author

Fixed

@xaksis xaksis merged commit 4011ad0 into xaksis:master May 18, 2020
@p0psicles
Copy link
Collaborator

@jjmartucci can you help me explain what the exact issue is, that is fixed? Because I asumed that if you selected "All", it should return in the @on-per-page-change event, also that the keyword 'All'. But it's returning the total number of rows for me?

@jjmartucci
Copy link
Contributor Author

@jjmartucci can you help me explain what the exact issue is, that is fixed? Because I asumed that if you selected "All", it should return in the @on-per-page-change event, also that the keyword 'All'. But it's returning the total number of rows for me?

The initial issue was that if you selected "ALL" in the per-page dropdown, then changed the search criteria, the "ALL" text would disappear from the dropdown.

@p0psicles
Copy link
Collaborator

Ok, tnx. Is clear now.

Hmm, i "solved" my issue by comparing the total rows that you get back when selecting all, to the total rows count. And then storing the perPage value as -1

p0psicles pushed a commit to p0psicles/vue-good-table that referenced this pull request Jun 24, 2020
…s#684)

* Fixes issue with All in per page dropdown not staying selected when total changes

Co-authored-by: Joe Martucci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants