-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue with All in per page dropdown not staying selected #684
Conversation
Hi @xaksis it looks like this is still an issue in the latest release, what would it take to get it out for the next one? |
ooh, thanks for pinging. I'll make sure it goes out in this weekend's release. Will review and let you know if there are any changes needed by Wed. Thank you for your patience, @jjmartucci! |
hey @jjmartucci could you please remove the built files from your PR. Just the source changes are fine. |
Fixed |
@jjmartucci can you help me explain what the exact issue is, that is fixed? Because I asumed that if you selected "All", it should return in the |
The initial issue was that if you selected "ALL" in the per-page dropdown, then changed the search criteria, the "ALL" text would disappear from the dropdown. |
Ok, tnx. Is clear now. Hmm, i "solved" my issue by comparing the total rows that you get back when selecting all, to the total rows count. And then storing the perPage value as -1 |
…s#684) * Fixes issue with All in per page dropdown not staying selected when total changes Co-authored-by: Joe Martucci <[email protected]>
Addresses issue 676 #676