Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Backport #11032 to 4.6.0 (#11040) #11042

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Backport #11032 to 4.6.0 (#11040) #11042

merged 1 commit into from
Jun 15, 2020

Conversation

samhouts
Copy link
Member

@samhouts samhouts commented Jun 14, 2020 •
edited
Loading

@samhouts @jsuarezruiz @hartez
Backport #11032 to 4.6.0 (#11040)
5b8a1a0 
* [iOS] Fix BackgroundColor issue with Frame (#11032)

* Fixed regression issue with Frame

* Removed wrong set of BackgroundColor to null

* Fix FrameRenderer background;
Make Frame CornerRadius test actually count;
Fix Frame BackgroundColor consistency test;

* Make the radius bigger to get the shadow out of the way

Co-authored-by: E.Z. Hart <[email protected]>

fixes #11031

* Remove ignore attribute now that 9625 is fixed

Co-authored-by: Javier Suárez <[email protected]>
Co-authored-by: E.Z. Hart <[email protected]>
@samhouts samhouts merged commit 43f09e2 into 4.5.0 Jun 15, 2020
@samhouts samhouts deleted the cp-11032-4.5.0 branch June 15, 2020 22:43
@StephaneDelcroix StephaneDelcroix mentioned this pull request Jun 18, 2020
Closed
@samhouts samhouts modified the milestones: 4.8.0, 4.6.0, 4.7.0 Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

@rmarinho rmarinho Awaiting requested review from rmarinho

Assignees

@rmarinho rmarinho

@jsuarezruiz jsuarezruiz

Labels
4.5.0 regression on 4.5.0 a/frame p/iOS 🍎 t/bug 🐛
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@samhouts @rmarinho @jsuarezruiz