[Enhancement] Expander control #9044

AndreiMisiukevich · 2019-12-29T21:06:56Z

Description of Change

Hi folks,
Currently, there is no expander control in the XF box.
Perhaps this control will be useful for many developers.

I tried to align API according to Windows Expander:
https://docs.microsoft.com/en-us/windows/communitytoolkit/controls/expander

API Changes

Added:

Expander control

public class Expander 
{
	public event EventHandler Tapped;

	public View Header { get; set; }

	public View Content { get; set; }

	public DataTemplate ContentTemplate { get; set; }

	public bool IsExpanded { get; set; }

	public uint ExpandAnimationLength { get; set; }

	public uint CollapseAnimationLength { get; set; }

	public Easing ExpandAnimationEasing { get; set; }

	public Easing CollapseAnimationEasing { get; set; }

	public ExpanderState State { get; set; }

	public object CommandParameter { get; set; }

	public ICommand Command { get; set; }

	public ICommand ForceUpdateSizeCommand { get; set; }

	public double Spacing { get; set; }
}

public enum ExpanderState
{
	Expanding,
	Expanded,
	Collapsing,
	Collapsed
}

So there are two approaches how to use Expander

Content Lazy Initialization. In this case, we should use ContentTemplate

<Expander>
	<Expander.Header>
		<Label Text="Header" />
	</Expander.Header>

	<Expander.ContentTemplate>
		<DataTemplate>
		<!-- Content here -->
		<ContentView x:Name="content"/>
		</DataTemplate>
	</Expander.ContentTemplate>
</Expander>

Non-lazy approach (for example if you need to set x:Name to the Content view.

<Expander>
	<Expander.Header>
		<Label Text="Header" />
	</Expander.Header>

         <!-- Content here -->
	<ContentView x:Name="content"/>
</Expander>

Platforms Affected

Core

Since this implementation is 100 percent cross-platform, the changes affect Core part only.

Testing Procedure

Run ControlGallery and navigate to the "Expander Gallery" via the search bar.
Play with the sample.

jfversluis

Very (very) first short sweep just one private keyword that isn't supposed to be there. I'll have another in-depth look tomorrow.

Thank you so much for your efforts Andrei! Especially this time of year!

Xamarin.Forms.Core/Expander.cs

acaliaro · 2019-12-30T17:48:55Z

It's a "control" (like ListView or CollectionView) or is a View that you can use inside ListView or CollectionView (like SwipeView...)

jfversluis · 2020-01-03T20:50:51Z

I've played around with it and it seems pretty solid.

The only thing I can't seem to figure out is how to use the Command on this. I've added the Command binding and tried to let all other Expanders close when one opens, I think that is something people would typically would want as well. But whatever I do, I can't seem to get the Command to fire. Is there something I am doing wrong?

AndreiMisiukevich · 2020-01-03T22:23:28Z

Comman is invoked each time when user taps it)

AndreiMisiukevich · 2020-01-03T22:39:07Z

You can observe IsExpanded property

AndreiMisiukevich · 2020-01-06T08:21:07Z

@jfversluis Hey Gerald, need you more explanation? :)

Command and Tapped are invoked once a user taps over a header. Also, we change IsExpanded to the opposite value.

jfversluis · 2020-01-06T09:03:57Z

But that is just the thing, it wasn't invoked when I tried it :) Did you try it? Does it work? If so, please show me how. Maybe you can add it to the sample?

AndreiMisiukevich · 2020-01-06T09:07:00Z

@jfversluis yes, I can extend the sample.

AndreiMisiukevich · 2020-01-06T10:54:15Z

@jfversluis check it please

jfversluis · 2020-01-06T13:45:50Z

Yes! Awesome, thanks! Not sure why, the command just didn't seem to fire for me.

Just retried on both iOS and Android and seems to work fine. Thank you for that!

Any specific reason you didn't add any tests?

AndreiMisiukevich · 2020-01-07T21:19:08Z

Yes! Awesome, thanks! Not sure why, the command just didn't seem to fire for me.

Just retried on both iOS and Android and seems to work fine. Thank you for that!

Any specific reason you didn't add any tests?

What kind of test do you mean? Unit or UI?

jfversluis · 2020-01-08T09:08:29Z

Ideally both! But I guess UI tests would make most sense for this :)

AndreiMisiukevich · 2020-01-08T09:57:44Z

@jfversluis yes. Frankly speaking, I do not understand what can be covered by unit tests in this class.

As for UI tests, I tried to run them at least a half year ago but didn't work out it. (Tried on Mac).

Also, I have no experience in writing UI tests

AndreiMisiukevich · 2020-01-10T11:45:58Z

@jfversluis I will appreciate your assistance in writing tests ;)

jfversluis · 2020-01-10T12:53:19Z

Sorry, was still on my todo list! Could you reach out to gerald.versluis [weird email sign] microsoft.com. Let's see if we can get the tests to run on your machine short term. If not, we might add something or do it later.

Thanks!

Co-Authored-By: Gerald Versluis <[email protected]>

mrwcjoughin · 2020-04-13T07:09:43Z

@AndreiMisiukevich by "100 percent cross-platform" does this mean it works on the macOS, UWP, WPF, and GTK targets of Xamarin.Forms as well?

AndreiMisiukevich · 2020-04-13T07:36:48Z

Well, basically it should work, but I don’t promise that

On Mon, Apr 13, 2020 at 10:09 Matthew Joughin ***@***.***> wrote: @AndreiMisiukevich <https://github.com/AndreiMisiukevich> by "100 percent cross-platform" does this mean it works on the macOS, UWP, WPF, and GTK targets of Xamarin.Forms as well? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9044 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNH4DUWROC5HZWWPMQSEWTRMK3ELANCNFSM4KBCQFZA> .

-- *Andrei Misiukevich* *Lead Software Engineer at ISsoft Solutions* *mobile: *+375 29 <+375%2017%20389%200100>303 40 07 Email: [email protected] Skype: csi.andreymisyukevich *Minsk,* *Belarus *(GMT+3)

Tommigun1980 · 2020-04-16T22:49:35Z

Hi.

How does the component calculate the space for the content when expanded? As a test I added the expander around a vertical chat list of mine, and this is the result:

As can be seen, the expander only shows around half of the height of the content. Is this a bug or am I doing something wrong?
I set the header up as such:
<StackLayout Orientation="Horizontal"> <Label Text="Test2" /> <Label Text="^" HorizontalOptions="EndAndExpand" /> </StackLayout>

Just having a label is of course not enough to denote a foldable area, as the customer would never know it's a tappable widget. So I wanted to test having an upwards arrow indicator that turns into a downwards arrow when expanded. I couldn't find any easy way of doing it. Please advice on how to add a visual element that toggles between two states depending on whether the expander is folded or not. If this is not supported I'd urge to add support for it as I can't see much use for an expander that can't visualise its state.

Thank you.

AndreiMisiukevich · 2020-04-16T22:55:14Z

Hi.

How does the component calculate the space for the content when expanded? As a test I added the expander around a vertical chat list of mine, and this is the result:

As can be seen, the expander only shows around half of the height of the content. Is this a bug or am I doing something wrong?

I set the header up as such:
<StackLayout Orientation="Horizontal"> <Label Text="Test2" /> <Label Text="^" HorizontalOptions="EndAndExpand" /> </StackLayout>

Just having a label is of course not enough to denote a foldable area, as the customer would never know it's a tappable widget. So I wanted to test having an upwards arrow indicator that turns into a downwards arrow when expanded. I couldn't find any easy way of doing it. Please advice on how to add a visual element that toggles between two states depending on whether the expander is folded or not. If this is not supported I'd urge to add support for it as I can't see much use for an expander that can't visualise its state.

Thank you.

Do you use ListView?
I don't think this control will work with ListView. Now there are several bugs filled for Expander+CollectionView.

Try to user ScrollView+StackLayout. Should work

Tommigun1980 · 2020-04-16T22:59:12Z

Hi.

How does the component calculate the space for the content when expanded? As a test I added the expander around a vertical chat list of mine, and this is the result:

As can be seen, the expander only shows around half of the height of the content. Is this a bug or am I doing something wrong?

I set the header up as such:
<StackLayout Orientation="Horizontal"> <Label Text="Test2" /> <Label Text="^" HorizontalOptions="EndAndExpand" /> </StackLayout>

Just having a label is of course not enough to denote a foldable area, as the customer would never know it's a tappable widget. So I wanted to test having an upwards arrow indicator that turns into a downwards arrow when expanded. I couldn't find any easy way of doing it. Please advice on how to add a visual element that toggles between two states depending on whether the expander is folded or not. If this is not supported I'd urge to add support for it as I can't see much use for an expander that can't visualise its state.
Thank you.

Do you use ListView?
I don't think this control will work with ListView. Now there are several bugs filled for Expander+CollectionView.

Try to user ScrollView+StackLayout. Should work

Thank you for the reply.

I am using a combination of virtualised rendering and collection views. The vertical part is done by a virtualised layout. I can play around with removing it but would rather see all scenarios supported.

Imho one of the largest drawbacks with Xamarin is that you can't just add UI components and have things work, as there's always some incompatibilities between the components. I don't think this should make its way into the main repo unless it works in all scenarios. It is not a good look if you have to rewrite your UIs several times just to find a permutation of components that works.

Also, any pointers regarding toggling a visual element, which I think is mandatory for the consumers to understand that it is a foldable element? I really think it should be doable straight in XAML.

Thanks!

AndreiMisiukevich · 2020-04-16T23:09:04Z

That is why this control is under experimental feature-flag

benazir46 · 2020-05-14T11:27:53Z

If I generate a list of expanders and add it to a StakeLayout one by one, iOS works most of the time, but Android crashes on first or second time I tap the expander header. Here are the stack traces for both iOS and Android:

System.ArgumentException: NaN is not a valid value for Height

iOS:

  at Xamarin.Forms.TemplatedView.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00056] in D:\a\1\s\Xamarin.Forms.Core\TemplatedView.cs:46 
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783 
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659 
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132 
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717 
  at Xamarin.Forms.StackLayout.CalculateNaiveLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, Xamarin.Forms.StackOrientation orientation, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint) [0x000a8] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:163 
  at Xamarin.Forms.StackLayout.CalculateLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint, System.Boolean processExpanders) [0x00058] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:123 
  at Xamarin.Forms.StackLayout.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00019] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:80 
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783 
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659 
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132 
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717 
  at Xamarin.Forms.TemplatedView.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x0003c] in D:\a\1\s\Xamarin.Forms.Core\TemplatedView.cs:43 
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783 
  at Xamarin.Forms.Expander.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x0000b] in D:\a\1\s\Xamarin.Forms.Core\Expander.cs:76 
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659 
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132 
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717 
  at Xamarin.Forms.StackLayout.CalculateNaiveLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, Xamarin.Forms.StackOrientation orientation, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint) [0x000a8] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:163 
  at Xamarin.Forms.StackLayout.CalculateLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint, System.Boolean processExpanders) [0x00058] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:123 
  at Xamarin.Forms.StackLayout.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00019] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:80 
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783 
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659 
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132 
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717 
  at Xamarin.Forms.TemplatedView.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x0003c] in D:\a\1\s\Xamarin.Forms.Core\TemplatedView.cs:43 
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783 
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659 
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132 
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717 
  at Xamarin.Forms.TemplatedView.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x0003c] in D:\a\1\s\Xamarin.Forms.Core\TemplatedView.cs:43 
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783 
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659 
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132 
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717 
  at Xamarin.Forms.StackLayout.CalculateNaiveLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, Xamarin.Forms.StackOrientation orientation, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint) [0x000a8] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:163 
  at Xamarin.Forms.StackLayout.CalculateLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint, System.Boolean processExpanders) [0x00058] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:123 
  at Xamarin.Forms.StackLayout.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00019] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:80 
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783 
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659 
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132 
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717 
  at Xamarin.Forms.TemplatedView.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x0003c] in D:\a\1\s\Xamarin.Forms.Core\TemplatedView.cs:43 
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783 
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659 
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132 
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717 
  at Xamarin.Forms.StackLayout.CalculateNaiveLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, Xamarin.Forms.StackOrientation orientation, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint) [0x000a8] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:163 
  at Xamarin.Forms.StackLayout.CalculateLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint, System.Boolean processExpanders) [0x00058] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:123 
  at Xamarin.Forms.StackLayout.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00019] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:80 
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783 
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659 
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132 
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717 
  at Xamarin.Forms.StackLayout.CalculateNaiveLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, Xamarin.Forms.StackOrientation orientation, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint) [0x000a8] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:163 
  at Xamarin.Forms.StackLayout.CalculateLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint, System.Boolean processExpanders) [0x00058] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:123 
  at Xamarin.Forms.StackLayout.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00019] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:80 
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783 
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659 
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132 
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717 
  at Xamarin.Forms.ScrollView.LayoutChildren (System.Double x, System.Double y, System.Double width, System.Double height) [0x000e1] in D:\a\1\s\Xamarin.Forms.Core\ScrollView.cs:236 
  at Xamarin.Forms.Layout.UpdateChildrenLayout () [0x00158] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:266 
  at Xamarin.Forms.Layout.OnSizeAllocated (System.Double width, System.Double height) [0x0000f] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:224 
  at Xamarin.Forms.VisualElement.SizeAllocated (System.Double width, System.Double height) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:805 
  at Xamarin.Forms.Layout.ResolveLayoutChanges () [0x0005c] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:392 
  at Foundation.NSAsyncActionDispatcher.Apply () [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/13.18.1.31/src/Xamarin.iOS/Foundation/NSAction.cs:152 
--- End of stack trace from previous location where exception was thrown ---


  at (wrapper managed-to-native) UIKit.UIApplication.UIApplicationMain(int,string[],intptr,intptr)
  at UIKit.UIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate) [0x00005] in /Library/Frameworks/Xamarin.iOS.framework/Versions/13.18.1.31/src/Xamarin.iOS/UIKit/UIApplication.cs:86 
  at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x0000e] in /Library/Frameworks/Xamarin.iOS.framework/Versions/13.18.1.31/src/Xamarin.iOS/UIKit/UIApplication.cs:65 
  at Health4LifeApp.iOS.Application.Main (System.String[] args) [0x00001] in /Users/benazir/Documents/XamarinTest-app/XamarinTestApp/XamarinTestApp.iOS/Main.cs:17

Android:

System.ArgumentException: NaN is not a valid value for Height
  at Xamarin.Forms.Size.set_Height (System.Double value) [0x00008] in D:\a\1\s\Xamarin.Forms.Core\Size.cs:51
  at Xamarin.Forms.TemplatedView.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00056] in D:\a\1\s\Xamarin.Forms.Core\TemplatedView.cs:46
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717
  at Xamarin.Forms.StackLayout.CalculateNaiveLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, Xamarin.Forms.StackOrientation orientation, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint) [0x000a8] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:163
  at Xamarin.Forms.StackLayout.CalculateLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint, System.Boolean processExpanders) [0x00058] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:123
  at Xamarin.Forms.StackLayout.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00019] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:80
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717
  at Xamarin.Forms.TemplatedView.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x0003c] in D:\a\1\s\Xamarin.Forms.Core\TemplatedView.cs:43
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783
  at Xamarin.Forms.Expander.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x0000b] in D:\a\1\s\Xamarin.Forms.Core\Expander.cs:76
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717
  at Xamarin.Forms.StackLayout.CalculateNaiveLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, Xamarin.Forms.StackOrientation orientation, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint) [0x000a8] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:163
  at Xamarin.Forms.StackLayout.CalculateLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint, System.Boolean processExpanders) [0x00058] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:123
  at Xamarin.Forms.StackLayout.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00019] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:80
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717
  at Xamarin.Forms.TemplatedView.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x0003c] in D:\a\1\s\Xamarin.Forms.Core\TemplatedView.cs:43
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717
  at Xamarin.Forms.TemplatedView.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x0003c] in D:\a\1\s\Xamarin.Forms.Core\TemplatedView.cs:43
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717
  at Xamarin.Forms.StackLayout.CalculateNaiveLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, Xamarin.Forms.StackOrientation orientation, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint) [0x000a8] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:163
  at Xamarin.Forms.StackLayout.CalculateLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint, System.Boolean processExpanders) [0x00058] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:123
  at Xamarin.Forms.StackLayout.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00019] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:80
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717
  at Xamarin.Forms.TemplatedView.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x0003c] in D:\a\1\s\Xamarin.Forms.Core\TemplatedView.cs:43
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717
  at Xamarin.Forms.StackLayout.CalculateNaiveLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, Xamarin.Forms.StackOrientation orientation, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint) [0x000a8] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:163
  at Xamarin.Forms.StackLayout.CalculateLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint, System.Boolean processExpanders) [0x00058] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:123
  at Xamarin.Forms.StackLayout.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00019] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:80
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717
  at Xamarin.Forms.StackLayout.CalculateNaiveLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, Xamarin.Forms.StackOrientation orientation, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint) [0x000a8] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:163
  at Xamarin.Forms.StackLayout.CalculateLayout (Xamarin.Forms.StackLayout+LayoutInformation layout, System.Double x, System.Double y, System.Double widthConstraint, System.Double heightConstraint, System.Boolean processExpanders) [0x00058] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:123
  at Xamarin.Forms.StackLayout.OnSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00019] in D:\a\1\s\Xamarin.Forms.Core\StackLayout.cs:80
  at Xamarin.Forms.VisualElement.OnMeasure (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:783
  at Xamarin.Forms.VisualElement.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00053] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:659
  at Xamarin.Forms.Layout.GetSizeRequest (System.Double widthConstraint, System.Double heightConstraint) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:132
  at Xamarin.Forms.VisualElement.Measure (System.Double widthConstraint, System.Double heightConstraint, Xamarin.Forms.MeasureFlags flags) [0x00054] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:717
  at Xamarin.Forms.ScrollView.LayoutChildren (System.Double x, System.Double y, System.Double width, System.Double height) [0x000e1] in D:\a\1\s\Xamarin.Forms.Core\ScrollView.cs:236
  at Xamarin.Forms.Layout.UpdateChildrenLayout () [0x00158] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:266
  at Xamarin.Forms.Layout.OnSizeAllocated (System.Double width, System.Double height) [0x0000f] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:224
  at Xamarin.Forms.VisualElement.SizeAllocated (System.Double width, System.Double height) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\VisualElement.cs:805
  at Xamarin.Forms.Layout.ResolveLayoutChanges () [0x0005c] in D:\a\1\s\Xamarin.Forms.Core\Layout.cs:392
  at Java.Lang.Thread+RunnableImplementor.Run () [0x00008] in <cedd971fdca5498396de4148fed1e5b1>:0
  at Java.Lang.IRunnableInvoker.n_Run (System.IntPtr jnienv, System.IntPtr native__this) [0x00008] in <cedd971fdca5498396de4148fed1e5b1>:0
  at at (wrapper dynamic-method) Android.Runtime.DynamicMethodNameCounter.1(intptr,intptr)

AndreiMisiukevich · 2020-05-14T17:02:08Z

@benazir46
It would be better to fill a new ticked with the attached sample for reproducing this issue.

LeoJHarris · 2020-05-26T01:34:45Z

Hey @AndreiMisiukevich jumping in to say congrats on getting this component into the Xamarin Forms project! 🥇

AndreiMisiukevich · 2020-05-26T07:00:37Z

Hey @AndreiMisiukevich jumping in to say congrats on getting this component into the Xamarin Forms project! 🥇

Thanks, mate)

AndreiMisiukevich requested a review from StephaneDelcroix as a code owner December 29, 2019 21:06

AndreiMisiukevich mentioned this pull request Dec 29, 2019

Make Expander control AndreiMisiukevich/ExpandableView#33

Closed

jfversluis suggested changes Dec 29, 2019

View reviewed changes

Xamarin.Forms.Core/Expander.cs Outdated Show resolved Hide resolved

AndreiMisiukevich requested a review from jfversluis December 29, 2019 21:33

samhouts added the ControlGallery label Jan 1, 2020

samhouts assigned jfversluis Jan 2, 2020

AndreiMisiukevich force-pushed the expander branch from 7dcddb7 to f3aee53 Compare January 6, 2020 09:38

samhouts added t/enhancement ➕ F100 API-change Heads-up to reviewers that this PR may contain an API change swipeview a/swipeview and removed swipeview a/swipeview labels Jan 8, 2020

AndreiMisiukevich and others added 13 commits April 3, 2020 17:11

Expander initial commit

75ca65b

updated Expander

a3fe78e

tab fixes

74d5cca

added spacing property

2b56286

added sample gallery page

f2f668d

removed useless class

a701234

updated sample

f5966d3

cleaned code

aaa9378

Update Xamarin.Forms.Core/Expander.cs

d699f53

Co-Authored-By: Gerald Versluis <[email protected]>

updated sample

ec3965f

UITest ExpanderView (#3)

c172d5b

removed empty line

00c3c8a

- expander flag

1878c2a

PureWeen force-pushed the expander branch from 368299b to 1878c2a Compare April 3, 2020 23:13

samhouts added the a/expander label Apr 4, 2020

samhouts merged commit fdad567 into xamarin:4.6.0 Apr 4, 2020

samhouts added this to the 4.6.0 milestone Apr 9, 2020

AndreiMisiukevich deleted the expander branch April 16, 2020 22:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Expander control #9044

[Enhancement] Expander control #9044

AndreiMisiukevich commented Dec 29, 2019 •

edited

Loading

jfversluis left a comment

acaliaro commented Dec 30, 2019

jfversluis commented Jan 3, 2020

AndreiMisiukevich commented Jan 3, 2020

AndreiMisiukevich commented Jan 3, 2020

AndreiMisiukevich commented Jan 6, 2020

jfversluis commented Jan 6, 2020

AndreiMisiukevich commented Jan 6, 2020

AndreiMisiukevich commented Jan 6, 2020

jfversluis commented Jan 6, 2020

AndreiMisiukevich commented Jan 7, 2020

jfversluis commented Jan 8, 2020

AndreiMisiukevich commented Jan 8, 2020

AndreiMisiukevich commented Jan 10, 2020

jfversluis commented Jan 10, 2020

mrwcjoughin commented Apr 13, 2020

AndreiMisiukevich commented Apr 13, 2020 via email

Tommigun1980 commented Apr 16, 2020 •

edited

Loading

AndreiMisiukevich commented Apr 16, 2020

Tommigun1980 commented Apr 16, 2020 •

edited

Loading

AndreiMisiukevich commented Apr 16, 2020

benazir46 commented May 14, 2020

AndreiMisiukevich commented May 14, 2020

LeoJHarris commented May 26, 2020

AndreiMisiukevich commented May 26, 2020

[Enhancement] Expander control #9044

[Enhancement] Expander control #9044

Conversation

AndreiMisiukevich commented Dec 29, 2019 • edited Loading

Description of Change

API Changes

Platforms Affected

Testing Procedure

jfversluis left a comment

Choose a reason for hiding this comment

acaliaro commented Dec 30, 2019

jfversluis commented Jan 3, 2020

AndreiMisiukevich commented Jan 3, 2020

AndreiMisiukevich commented Jan 3, 2020

AndreiMisiukevich commented Jan 6, 2020

jfversluis commented Jan 6, 2020

AndreiMisiukevich commented Jan 6, 2020

AndreiMisiukevich commented Jan 6, 2020

jfversluis commented Jan 6, 2020

AndreiMisiukevich commented Jan 7, 2020

jfversluis commented Jan 8, 2020

AndreiMisiukevich commented Jan 8, 2020

AndreiMisiukevich commented Jan 10, 2020

jfversluis commented Jan 10, 2020

mrwcjoughin commented Apr 13, 2020

AndreiMisiukevich commented Apr 13, 2020 via email

Tommigun1980 commented Apr 16, 2020 • edited Loading

AndreiMisiukevich commented Apr 16, 2020

Tommigun1980 commented Apr 16, 2020 • edited Loading

AndreiMisiukevich commented Apr 16, 2020

benazir46 commented May 14, 2020

AndreiMisiukevich commented May 14, 2020

LeoJHarris commented May 26, 2020

AndreiMisiukevich commented May 26, 2020

AndreiMisiukevich commented Dec 29, 2019 •

edited

Loading

Tommigun1980 commented Apr 16, 2020 •

edited

Loading

Tommigun1980 commented Apr 16, 2020 •

edited

Loading