Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

CameraView: only request microphone permission when CaptureMode is set to Video in UWP #1963

Merged
merged 3 commits into from
May 1, 2023
Merged

CameraView: only request microphone permission when CaptureMode is set to Video in UWP #1963

merged 3 commits into from
May 1, 2023

Conversation

MFinkBK
Copy link
Contributor

@MFinkBK MFinkBK commented Apr 21, 2023

Description of Bug

This fixes the CameraView on UWP to request microphone permission when CaptureMode is only set to Photo.

Issues Fixed

Behavioral Changes

The UWP app can then remove the microphone permission if not use anywhere else.

PR Checklist

  • Has a linked Issue, and the Issue has been approved
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

pictos
pictos approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfversluis jfversluis enabled auto-merge (squash) May 1, 2023 08:40
@jfversluis jfversluis merged commit 75886e1 into xamarin:main May 1, 2023
@MFinkBK MFinkBK deleted the cameraview-uwp-microphone-permission branch May 4, 2023 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jfversluis jfversluis jfversluis approved these changes

@pictos pictos pictos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [CameraView] [UWP] CameraView asks for access to the microphone in CaptureMode="Photo"
3 participants
@MFinkBK @jfversluis @pictos