Skip to content

Commit

Permalink
Update to new package names
Browse files Browse the repository at this point in the history
Thanks @pjcollins for the heads up #11175 (comment)
  • Loading branch information
Sebastien Pouliot committed Apr 15, 2021
1 parent 56bb3d7 commit ed3ac89
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
7 changes: 1 addition & 6 deletions builds/package-download/download-packages.proj
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,8 @@
<!-- Download any runtime packs as specified using the PackageRuntimeIdentifiers property -->
<PackageRuntimeIdentifiers Include="$(PackageRuntimeIdentifiers.Split(' '))" />

<!-- Download the mono osx pack as well -->
<!-- I wasn't able to figure out how to only do this if 'osx-x64'/'osx-arm64' is already included -->
<PackageRuntimeIdentifiers Include="Mono.osx-x64" />
<PackageRuntimeIdentifiers Include="Mono.osx-arm64" />

<!-- download the runtime packs -->
<PackageDownload Include="@(PackageRuntimeIdentifiers -> 'Microsoft.NETCore.App.Runtime.%(Identity)')" Version="[$(BundledNETCorePlatformsPackageVersion)]" />
<PackageDownload Include="@(PackageRuntimeIdentifiers -> 'Microsoft.NETCore.App.Runtime.Mono.%(Identity)')" Version="[$(BundledNETCorePlatformsPackageVersion)]" />

<!-- download the reference assemblies -->
<PackageDownload Include="microsoft.netcore.app.ref" Version="[$(BundledNETCorePlatformsPackageVersion)]" />
Expand Down
2 changes: 2 additions & 0 deletions dotnet/targets/Xamarin.Shared.Sdk.DefaultItems.targets
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

<!-- Don't include default Compile items for binding projects, because that would pick up ApiDefinition.cs and StructsAndEnums.cs -->
<EnableDefaultCompileItems Condition=" '$(IsBindingProject)' == 'true' ">false</EnableDefaultCompileItems>

<UseMonoRuntime Condition=" '$(UseMonoRuntime)' == '' ">true</UseMonoRuntime>
</PropertyGroup>

<!-- Architecture -->
Expand Down

1 comment on commit ed3ac89

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent

Please sign in to comment.