DTSDKBuild is incorrect in the Info.plist for macOS and Mac Catalyst apps #19733
Comments
rolfbjarne
added a commit
to rolfbjarne/Xamarin.MacDev
that referenced
this issue
Jan 3, 2024
…ios@19733. We were accidentally getting the ProductBuildVersion value (which is used for DTSDKBuild) from the system, not from the SDK used during the build. This happened because we were trying to Path.Combine two rooted paths - in which case Path.Combine returns the second path, without combining anything. The fix is to compute the path of the plist where the ProductBuildVersion value is located correctly. Fixing the Path.Combine issue also revealed that the first path passed to Path.Combine was wrong, so that got fixed too. And finally make sure we don't Path.Combine two rooted paths anywhere else - in all other cases we're supposed to just use the second path without prepending the first, so just remove the Path.Combine call completely in those cases. Fixes xamarin/xamarin-macios#19733.
rolfbjarne
added a commit
to xamarin/Xamarin.MacDev
that referenced
this issue
Jan 3, 2024
…ios@19733. (#116) We were accidentally getting the ProductBuildVersion value (which is used for DTSDKBuild) from the system, not from the SDK used during the build. This happened because we were trying to Path.Combine two rooted paths - in which case Path.Combine returns the second path, without combining anything. The fix is to compute the path of the plist where the ProductBuildVersion value is located correctly. Fixing the Path.Combine issue also revealed that the first path passed to Path.Combine was wrong, so that got fixed too. And finally make sure we don't Path.Combine two rooted paths anywhere else - in all other cases we're supposed to just use the second path without prepending the first, so just remove the Path.Combine call completely in those cases. Fixes xamarin/xamarin-macios#19733.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The DTSDKBuild value we put in the Info.plist during the build is incorrect, we put the system's ProductBuildVersion, instead of the SDK's ProductBuildVersion.
Depending on which macOS version the build machine has, developers might get this when trying to publish a build:
See #13300 (comment) for more info.
The text was updated successfully, but these errors were encountered: