Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for binding projects in Mac Catalyst. Fixes #10286. #10295

Merged
merged 5 commits into from
Dec 17, 2020
Merged

Add support for binding projects in Mac Catalyst. Fixes #10286. #10295

merged 5 commits into from
Dec 17, 2020

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Dec 15, 2020 •
edited
Loading

  • Build our native test libraries for Mac Catalyst.
  • Add the required MSBuild targets file for Mac Catalyst binding projects to work
  • Fix up a few things in mtouch and msbuild logic.

This makes the framework-test and interdependent-binding-projects tests green.

Fixes #10286.
Partial fix for #10217.

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Dec 15, 2020
@rolfbjarne rolfbjarne mentioned this pull request Dec 16, 2020
Closed
30 tasks
@rolfbjarne
Copy link
Member Author

build

@monojenkins
Copy link
Collaborator

Build success
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

@rolfbjarne rolfbjarne merged commit 1582bf4 into xamarin:main Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

@emaf emaf Awaiting requested review from emaf emaf is a code owner

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mac Catalyst: add support for binding projects
4 participants
@rolfbjarne @monojenkins @spouliot @tj-devel709