[dotnet] Handle lib prefix for P/Invokes for runtime native libraries
#11158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipnavara
changed the title
lib prefix for P/Invokes for runtime native libraries
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
spouliot
approved these changes
Apr 8, 2021
| #if NET | ||
| sw.WriteLine ($"\tmono_dllmap_insert (NULL, \"libSystem.Native\", NULL, \"{mono_native_lib}\", NULL);"); | ||
| sw.WriteLine ($"\tmono_dllmap_insert (NULL, \"libSystem.Security.Cryptography.Native.Apple\", NULL, \"{mono_native_lib}\", NULL);"); | ||
| sw.WriteLine ($"\tmono_dllmap_insert (NULL, \"libSystem.Net.Security.Native\", NULL, \"{mono_native_lib}\", NULL);"); |
There was a problem hiding this comment.
libSystem.IO.Compression.Native.dylib might be needed too.
It's shipped so it's likely used somewhere in the BCL (have not checked).
That can wait for the removal of the .dylib from the app bundle since it's the only way to test it properly.
There was a problem hiding this comment.
It's not needed for "Hello World" but it's needed in general. I hesitate to do more changes here since it's likely going to be replaced by PINVOKE_OVERRIDE callback anyway (unless there are some AOT implications from using dllmap).
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results16 tests failed, 78 tests passed.Failed tests
Pipeline on Agent BOT-0189.Catalina |
|
The tests fail because of dotnet/runtime#47533 and dotnet/runtime#47910. This is expected and I can add a workaround. |
mandel-macaque
approved these changes
Apr 8, 2021
mandel-macaque
added
community
dalexsoto
approved these changes
Apr 9, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. Pipeline on Agent |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. Pipeline on Agent |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results5 tests failed, 93 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur |
…en native libraries are dynamically linked
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results19 tests failed, 79 tests passed.Failed tests
Pipeline on Agent XAMBOT-1110' |
|
Something really bad is going on in certain bots. |
|
JFYI I re-run some of the timed out tests locally and they worked. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results1 tests failed, 97 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur |
|
The last remaining failure ( |
|
Yes, that's an unrelated CI/xharness issue that we're tracking internally - https://github.com/xamarin/maccore/issues/2411 |
spouliot
approved these changes
Apr 10, 2021
spouliot
pushed a commit
to spouliot/xamarin-macios
that referenced
this pull request
Apr 14, 2021
With xamarin#11158 we do not load symbols from the dylibs - so we do not have to ship them. This makes the size comparison, between legacy and dotnet, more accurate since the dylibs were large binaries. https://gist.github.com/spouliot/9cad974b73b982404421e634f2a3a2b7
spouliot
added a commit
that referenced
this pull request
Apr 14, 2021
With #11158 we do not load symbols from the dylibs - so we do not have to ship them. This makes the size comparison, between legacy and dotnet, more accurate since the dylibs were large binaries. https://gist.github.com/spouliot/9cad974b73b982404421e634f2a3a2b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #11145