[dotnet] Add ICU support for iOS builds #11163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the invariant culture is currently shipping in .NET 5. (xamarin#9498)" This reverts commit 6a1e8ac.
and re-enable some tests for dotnet Part of the fix for xamarin#8906 Known Issues * [some Calendar are not the expected ones](dotnet/runtime#50859) * [No support for tvOS](dotnet/runtime#50912)
mandel-macaque
approved these changes
Apr 8, 2021
|
c.c. @emaf for msbuild changes |
dalexsoto
approved these changes
Apr 8, 2021
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results15 tests failed, 79 tests passed.Failed tests
Pipeline on Agent BOT-0189.Catalina |
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results1 tests failed, 93 tests passed.Failed tests
Pipeline on Agent XAMBOT-1093.Catalina' |
✅ Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diff🎉 All 94 tests passed 🎉Pipeline on Agent BOT-0189.Catalina |
emaf
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and re-enable some tests for dotnet
Part of the fix for #8906
Known Issues