[CoreVideo] Add support for Xcode13 beta 1. #11997
Conversation
Added new APIs from Xcode13, add missing ones that have been added in catalyst and enabled nullable in the manual code.
mandel-macaque
added
the
note-highlight
mandel-macaque
requested review from
dalexsoto,
rolfbjarne and
spouliot
as code owners
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
src/CoreVideo/CVPixelBuffer.cs
Outdated
| [SupportedOSPlatform ("tvos15.0")] | ||
| [SupportedOSPlatform ("macos12.0")] | ||
| [UnsupportedOSPlatform ("maccatalyst")] | ||
| [UnsupportedOSPlatform ("watchos")] |
There was a problem hiding this comment.
^ for NET it's done at the assembly-level
src/CoreVideo/CVPixelBufferPool.cs
Outdated
| @@ -159,7 +161,7 @@ public CVPixelBufferPool (NSDictionary poolAttributes, NSDictionary pixelBufferA | |||
| } | |||
|
|
|||
| public CVPixelBufferPool (CVPixelBufferPoolSettings settings, CVPixelBufferAttributes pixelBufferAttributes) | |||
| : this (settings.GetDictionary (), pixelBufferAttributes.GetDictionary ()) | |||
| : this (settings.GetDictionary () ?? new NSDictionary (), pixelBufferAttributes.GetDictionary () ?? new NSDictionary ()) | |||
There was a problem hiding this comment.
why ?
x.GetHandle is an extension method that will return IntPtr.Zero if x is null
Also you're creating two instances of the same, immutable instance of NSDictionary.
if CVPixelBufferPoolCreate does not accept null then it's incorrect and should be using GetNonNullHandle extension method
| #else | ||
| [Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), NoMacCatalyst] | ||
| #endif | ||
| [DllImport (Constants.CoreVideoLibrary)] |
There was a problem hiding this comment.
double check the native return type
you might need a [return: MarshalAs (UnmanagedType.I1)] to correctly convert the native bool
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
src/CoreVideo/CVPixelBuffer.cs
Outdated
| [SupportedOSPlatform ("ios15.0")] | ||
| [SupportedOSPlatform ("tvos15.0")] | ||
| [SupportedOSPlatform ("macos12.0")] | ||
| [UnsupportedOSPlatform ("maccatalyst")] | ||
| [UnsupportedOSPlatform ("watchos")] |
There was a problem hiding this comment.
Like this?
| [SupportedOSPlatform ("ios15.0")] | |
| [SupportedOSPlatform ("tvos15.0")] | |
| [SupportedOSPlatform ("macos12.0")] | |
| [UnsupportedOSPlatform ("maccatalyst")] | |
| [UnsupportedOSPlatform ("watchos")] | |
| [assembly: SupportedOSPlatform ("ios15.0")] | |
| [assembly: SupportedOSPlatform ("tvos15.0")] | |
| [assembly: SupportedOSPlatform ("macos12.0")] | |
| [assembly: UnsupportedOSPlatform ("maccatalyst")] |
There was a problem hiding this comment.
no, my comment was that watchos is already handled with an assembly-level attribute (no need to repeat it)
There was a problem hiding this comment.
IOW those were fine
[SupportedOSPlatform ("ios15.0")]
[SupportedOSPlatform ("tvos15.0")]
[SupportedOSPlatform ("macos12.0")]
[UnsupportedOSPlatform ("maccatalyst")]
There was a problem hiding this comment.
ahhh see, I misunderstood, got it
Added new APIs from Xcode13, add missing ones that have been added in
catalyst and enabled nullable in the manual code.