Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Add .NET version of the fsharp test. #12359

Merged
merged 1 commit into from
Aug 6, 2021
Merged

[tests] Add .NET version of the fsharp test. #12359

merged 1 commit into from
Aug 6, 2021

Conversation

rolfbjarne
Copy link
Member

Partial fix for #10217.

@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Aug 5, 2021
@rolfbjarne rolfbjarne mentioned this pull request Aug 5, 2021
Closed
30 tasks
spouliot
spouliot approved these changes Aug 5, 2021
View reviewed changes
tests/common/mac/MacMain.fs
static member ThreadMonitor(obj : System.Object) =
let exit_code = obj :?> int
Thread.Sleep (3000)
Console.WriteLine ($"The process didn't exist within 3s of returning from Main. Assuming something is deadlocked, and will now exit immediately and forcefully (with exit code {exit_code}).")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exist -> exit

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

✅ API Diff (from PR only) (no change)
✅ Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 186 tests passed.

Failed tests

  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: Failed
  • DotNet tests: Failed (Execution failed with exit code 1)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 5404d3a into 0ffed97

@rolfbjarne
Copy link
Member Author

Test failures are unrelated

@rolfbjarne rolfbjarne merged commit 013054a into xamarin:main Aug 6, 2021
@rolfbjarne rolfbjarne deleted the dotnet-tests-fsharp branch August 6, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @spouliot @mandel-macaque